Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: service mode for segment displays #1616

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

jabdoa2
Copy link
Collaborator

@jabdoa2 jabdoa2 commented Nov 7, 2021

No description provided.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

shows:
service_door_open_segment_display:
- duration: -1
segment_displays:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I would have to modify for my segment display machine which has 2 16-segment displays (the top one is 16-segment and the bottom one is 8-segment) and not 4 segment displays. I don't think that's too big of a deal as it would be hard to provide configs for every common possible hardware setup. I'm sure 4 segment displays is a pretty common setup.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow you are quick! The idea is to provide default "slides" for dmd, lcd and segment displays. If you got "special" setups you could copy those and unload ours. If 2 16-digit displays is common you can also ship a set of slides for that as well.

I want to extend this to all our built-in modes such as high score, tilt, match, credits and bonus.

@jabdoa2 jabdoa2 merged commit faa9848 into dev Nov 8, 2021
@jabdoa2 jabdoa2 deleted the add_service_mode_for_segment_displays branch November 8, 2021 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants