Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create flash duty for light segment displays #1637

Merged
merged 3 commits into from
May 23, 2022
Merged

Create flash duty for light segment displays #1637

merged 3 commits into from
May 23, 2022

Conversation

cobra18t
Copy link
Collaborator

Segment flash is currently limited to 50%. Let's make it configurable.

@sonarcloud
Copy link

sonarcloud bot commented May 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cobra18t cobra18t requested a review from jabdoa2 May 23, 2022 00:27
jabdoa2
jabdoa2 approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@jabdoa2 jabdoa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jabdoa2 jabdoa2 merged commit da0ec7f into missionpinball:dev May 23, 2022
@jabdoa2
Copy link
Collaborator

jabdoa2 commented May 23, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabdoa2 jabdoa2 jabdoa2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cobra18t @jabdoa2