Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Speedometer Devices #1692

Merged
merged 5 commits into from
Jul 3, 2023
Merged

Enable Speedometer Devices #1692

merged 5 commits into from
Jul 3, 2023

Conversation

cobra18t
Copy link
Collaborator

A speedometer device was added back in 2021, but it was never tested or used. Here I am enabling it in its most basic form before making further enhancements.

Concern areas:

  • The MPF system clock may have too much jitter and too low a resolution to be an effective speedometer if the switches are too close together
  • Hardware timestamps may be required, but many systems do not support timestamps or handle them differently. OPP has a 1ms timestamp that restarts every 65 seconds, for example. Also, getting the timestamps is a separate transaction from getting the switch states. We may only want to grab hardware timestamps when absolutely required rather than burdening all switch updates with timestamp requests.

@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cobra18t cobra18t marked this pull request as ready for review July 3, 2023 19:01
@cobra18t cobra18t merged commit 0efcfd3 into missionpinball:dev Jul 3, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant