Add Player Vars to High Score Mode #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the high_score.py file to pass through both the player_num and the category of the award. This is pushed through a new unique event (to prevent breaking existing games). The high_score.yaml file is updated as well to show how to use these new features to create a new specific slide for the awards where player and machine variables should be shown.
|
Kudos, SonarCloud Quality Gate passed!
|
|
I don't know if we care about those two fails. I didn't touch that file, and it's odd it failed both Windows and Mac for 3.8 but passed the rest. I will leave that up to someone wiser than myself if it needs addressed, and how to address it. |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the high_score.py file to pass through both the player_num and the category of the award. This is pushed through a new unique event (to prevent breaking existing games). The high_score.yaml file is updated as well to show how to use these new features to create a new specific slide for the awards where player and machine variables should be shown.