add support for using * tag to return all devices #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, thanks! I just checked the tests, looks like there’s a test for tags you can jump onto here: |
|
Test updated. |
This reverts commit 9cdb7dd.
|
Kudos, SonarCloud Quality Gate passed!
|
toomanybrians
added a commit
to missionpinball/mpf-docs
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use case is to turn off all lights when a skill shot is hit (like Deadpool). I didn't want to tag every light with a tag like "all" or "*" to accomplish this, but if there is a better way or this feature seems problematic, no worries if this PR is declined.
I didn't see any existing tests on this area -- if there are any, I'm happy to add a new one for this change.