Enable dynamic speed in show_player and post elapsed time for a sequence_shot completion #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
toomanybrians
added a commit
to missionpinball/mpf-docs
that referenced
this pull request
Jul 7, 2023
avanwinkle
added a commit
to avanwinkle/mpf
that referenced
this pull request
Dec 30, 2023
avanwinkle
added a commit
to avanwinkle/mpf
that referenced
this pull request
Feb 4, 2024
avanwinkle
added a commit
to avanwinkle/mpf
that referenced
this pull request
Feb 22, 2024
avanwinkle
added a commit
that referenced
this pull request
Feb 22, 2024
Eval placeholder args in show update method (from #1702)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The speed parameter of a show_player did not allow dynamic placeholders. This change allows a show to be played using a variable speed.
It also adds the elapsed time from start to completion of a sequence shot. This can be used in troubleshooting sequence_shot timeouts or for estimating ball speed. The elapsed time is posted in the sequence shot "hit" event so that it can be easily used to trigger other things like a speed calculation.
Both of these enable a concept for an "airspinner"--a virtual spinner that measures ball speed using switches and uses LED strips or rings to create a strobing or spinning effect.