Support machine_path arg in MC production builds #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
avanwinkle
added a commit
to avanwinkle/mpf
that referenced
this pull request
Sep 13, 2023
…dle-mc-machine-path Support machine_path arg in MC production builds (cherry picked from commit f1fdc97)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the work done in #1612 , which added support for
machine_pathas a command line argument when building production bundles and the option to build and MPF bundle without MC.An oversight in that PR was that the
machine_patharg was not passed to MC, obviously because I wasn't using MC at the time (hence the option to skip the MC build). But for projects that do use MC, they need to have the custommachine_pathin that bundle too.This PR extends the custom
machine_pathfunctionality to the MC bundle, so that when both bundles are built they both use the custom path.