Ensure LED fade brightness is never negative #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where a FAST LED fade can sometimes calculate a negative brightness. The issue is caused by the fade's
start_timebeing after thecurrent_time.I've done much investigation into the issue and cannot figure out the root cause, aside from a possible floating-point rounding error that causes the two calls to
self.machine.clock.get_time()to yield slightly offset values. I found no systemic or regularly reproducible cause for the issue, so I cannot "fix" it at this time. Instead, just do a safety check to ensure the value is never negative.Also, did some linting cleanup while the file is changed.