Get emoji data from native

[pederjohnsen]

Adds function to get emoji data from native unicode emoji

This resolves #16 and resolves #193

[edit]
Thought I had already fixed it but seems the issues with some emojis as mentioned in #16 (comment) are still present here too.. If anyone has any thoughts as to why and how to fix it let me know 🙃

[ifiokjr]

This looks very helpful. Any chance it gets merged soon?

[nolanlawson]

It seems based on discussion in #16 that this still needs some more work?

[pederjohnsen]

Yes unfortunately it still needs more work, I've not got the time to revisit this at the moment, but once I have (unless someone else has had a look by then) I'll post an update in here 👌

[pederjohnsen]

@nolanlawson I've updated the code and it seems to work correctly for all emojis now...

This also includes an update to nimble-emoji-index.js which returns search results for the skin tone you've picked in the picker. If I remember correctly this isn't required for the getEmojiDataFromNative to work. But was another thing I needed for an app I'm working on. I could pull this out and create a separate PR if wanted 👍

[nolanlawson]

I've taken a quick look and provided some feedback. I think indeed that breaking it up into two PRs may be a good idea. If you also have a chance to add some Jest tests that would be grand. :)

[pederjohnsen]

Thanks for reviewing, I'll try and get on this over the weekend 👍

[pederjohnsen]

@nolanlawson I've updated the code and added some tests, let me know if you find anything else 👌

[nolanlawson]

This LGTM, I think the only thing missing is that it would be great to have a Jest test for this, since this is a pretty self-contained little util function. I don't think it should necessarily block this PR from being merged, though.

[pederjohnsen]

ab2f600 ? 🤔

[nolanlawson]

Oops, my bad, did not see the tests. Everything LGTM!

[pederjohnsen]

Thanks :) 🎉