Support case where showPreview is false but showSkinTones is true. Also add prepare script. #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary in order to be able to show skin tone picker even when one desires for the mouseover preview to be invisible. This is an important case because mouseover displays must be disabled in order to enable single click emoji typing on iOS without disabling the skin tone picker.
|
Could you provide some more details about what this PR is doing? I'm not sure I follow what exactly this fixes. Presumably mouseover is a desktop-only convention, but I suppose this change is mostly for mobile? Also the |
|
Nevermind, after reading through the CSS Tricks article and this PR again, I understand. You're not trying to solve the iOS hover issue per se - that's just what led you to want to hide the mouseover preview but show the skin tones. However that doesn't work, so you opened this PR. Got it. LGTM, merging! |
This was referenced Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to be able to disable the mouseover emoji preview area but still have showSkinTones available. In particular, in order to be able to use the component on iOS without having to double-click every time it is necessary to disable much mouseover behavior such as this. (see https://css-tricks.com/annoying-mobile-double-tap-link-issue/)
Also, it is useful to have a "prepare" script in the package.json so that it is possible to clone emoji-mart directly from a git repo without extra steps.