Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readAllNotifications message not working #14374

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

anatawa12
Copy link
Member

What

Fix #14367

readAllNotificationsメッセージにペイロードがないときに動かなくなっていたのを修正します

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Aug 7, 2024
Copy link
Contributor

github-actions bot commented Aug 7, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 39.92%. Comparing base (61eec93) to head (d2544a0).
Report is 260 commits behind head on develop.

Files Patch % Lines
...ckages/backend/src/server/api/stream/Connection.ts 12.50% 14 Missing ⚠️
...end/src/server/api/stream/channels/reversi-game.ts 25.00% 3 Missing ⚠️
packages/backend/src/misc/json-value.ts 50.00% 2 Missing ⚠️
...kend/src/server/api/stream/channels/queue-stats.ts 50.00% 1 Missing ⚠️
...end/src/server/api/stream/channels/server-stats.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14374       +/-   ##
============================================
- Coverage    66.21%   39.92%   -26.30%     
============================================
  Files          990     1544      +554     
  Lines       117137   190368    +73231     
  Branches      4489     2692     -1797     
============================================
- Hits         77568    75995     -1573     
- Misses       39538   113813    +74275     
- Partials        31      560      +529     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anatawa12 anatawa12 marked this pull request as ready for review August 7, 2024 08:52
@kakkokari-gtyih kakkokari-gtyih added this to the v2024.8.0 milestone Aug 7, 2024
Co-authored-by: Sayamame-beans <61457993+Sayamame-beans@users.noreply.github.com>
@syuilo
Copy link
Member

syuilo commented Aug 9, 2024

🙏
テスト追加できたりするかしら

@anatawa12
Copy link
Member Author

NotificationService.readAllNotificationが呼ばれたことがどうやってテストしたらいいかがいい方法が思いつかないので難しいかもです

@syuilo syuilo merged commit f509413 into misskey-dev:develop Aug 9, 2024
26 checks passed
@syuilo
Copy link
Member

syuilo commented Aug 9, 2024

🙏🏻

@anatawa12 anatawa12 deleted the fix-read-notifications branch August 9, 2024 07:04
LemonDouble pushed a commit to LemonDouble/misskey that referenced this pull request Aug 19, 2024
* refactor: add and use isJsonObject

* fix: readNotification message without body is not working

* docs(changelog): WSの`readAllNotifications` メッセージが `body` を持たない場合に動作しない問題

* Update CHANGELOG.md

Co-authored-by: Sayamame-beans <61457993+Sayamame-beans@users.noreply.github.com>

---------

Co-authored-by: Sayamame-beans <61457993+Sayamame-beans@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
4 participants