-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: signin の資格情報が足りないだけの場合はエラーにせず200を返すように #14700
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14700 +/- ##
===========================================
+ Coverage 39.67% 41.28% +1.60%
===========================================
Files 1548 1552 +4
Lines 194496 200224 +5728
Branches 2566 3579 +1013
===========================================
+ Hits 77174 82668 +5494
- Misses 116756 116955 +199
- Partials 566 601 +35 ☔ View full report in Codecov by Sentry. |
このPRによるapi.jsonの差分 |
うーん資格情報が足りない状態でのレスポンスに200は強い違和感を持ちますね 403が違うってのは多分そうなのですが、401は不適当ですし400あたりがよいと私は感じます |
|
tabun done |
ファイル名とかクラス名は変えなくても良い気がするわね |
もどした |
What
/signin
->/signin-flow
Why
Fix #14699
Additional info (optional)
Checklist