Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(frontend): 共有と埋込みコード生成を親子メニューにまとめる #14702

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kakkokari-gtyih
Copy link
Contributor

What

ログイン中のノートメニューでは、ブラウザの共有ボタンと埋め込みコード生成ボタンを親メニュー内にまとめるように

Why

ノートメニューが縦に長くなってきているので整理したい(コピー系もまとめることを考えたけど使用頻度が高そうなので除外した)

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 19.42%. Comparing base (fa06c59) to head (5444ce7).

Files with missing lines Patch % Lines
packages/frontend/src/scripts/get-note-menu.ts 0.00% 43 Missing ⚠️
packages/frontend/src/scripts/get-appear-note.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14702       +/-   ##
============================================
- Coverage    39.67%   19.42%   -20.26%     
============================================
  Files         1548      719      -829     
  Lines       194496   102083    -92413     
  Branches      2566      990     -1576     
============================================
- Hits         77174    19827    -57347     
+ Misses      116756    81707    -35049     
+ Partials       566      549       -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant