Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: アクセストークン発行時に通知するように #15422

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

lqvp
Copy link
Contributor

@lqvp lqvp commented Feb 7, 2025

What

  • アクセストークンを発行した際に通知を作成
    image

Why

resolve #13353

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added packages/frontend Client side specific issue/PR packages/backend Server side specific issue/PR packages/misskey-js labels Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 37.14286% with 22 lines in your changes missing coverage. Please review.

Project coverage is 40.32%. Comparing base (607bf60) to head (89e4a69).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...ackages/frontend/src/components/MkNotification.vue 0.00% 13 Missing ⚠️
packages/backend/src/models/Notification.ts 0.00% 4 Missing ⚠️
...ckend/src/server/api/endpoints/miauth/gen-token.ts 20.00% 4 Missing ⚠️
...ages/frontend/src/pages/settings/notifications.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #15422       +/-   ##
============================================
+ Coverage    18.82%   40.32%   +21.50%     
============================================
  Files          766     1611      +845     
  Lines       111400   210632    +99232     
  Branches      1234     4087     +2853     
============================================
+ Hits         20966    84941    +63975     
- Misses       89845   125081    +35236     
- Partials       589      610       +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -50962,6 +50962,7 @@
                         "achievementEarned",
                         "exportCompleted",
                         "login",
+                        "createToken",
                         "app",
                         "test",
                         "pollVote",
@@ -50988,6 +50989,7 @@
                         "achievementEarned",
                         "exportCompleted",
                         "login",
+                        "createToken",
                         "app",
                         "test",
                         "pollVote",
@@ -51205,6 +51207,7 @@
                         "achievementEarned",
                         "exportCompleted",
                         "login",
+                        "createToken",
                         "app",
                         "test",
                         "reaction:grouped",
@@ -51233,6 +51236,7 @@
                         "achievementEarned",
                         "exportCompleted",
                         "login",
+                        "createToken",
                         "app",
                         "test",
                         "reaction:grouped",
@@ -80689,6 +80693,30 @@
                 ]
               }
             },
+            "required": [
+              "id",
+              "createdAt",
+              "type"
+            ]
+          },
+          {
+            "type": "object",
+            "properties": {
+              "id": {
+                "type": "string",
+                "format": "id"
+              },
+              "createdAt": {
+                "type": "string",
+                "format": "date-time"
+              },
+              "type": {
+                "type": "string",
+                "enum": [
+                  "createToken"
+                ]
+              }
+            },
             "required": [
               "id",
               "createdAt",

Get diff files from Workflow Page

locales/en-US.yml Outdated Show resolved Hide resolved
packages/backend/src/types.ts Outdated Show resolved Hide resolved
@kakkokari-gtyih
Copy link
Contributor

Changelogへの追記をお願いします。Generalの節でかまいません

@kakkokari-gtyih kakkokari-gtyih added this to the v2025.2.1 milestone Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR packages/misskey-js
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

アクセストークン作成時に通知を発行した方が良い?
4 participants