Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate video thumbnails #4084

Merged
merged 2 commits into from
Feb 2, 2019
Merged

Conversation

mei23
Copy link
Contributor

@mei23 mei23 commented Feb 1, 2019

Summary

Resolve #3314, Resolve #3909, Resolve #4065
Related #3579 ?

動画にサムネイルを作成するようにしてます
video-thumbnail-generator => fluent-ffmpeg => ffmpegが必要
https://github.com/fluent-ffmpeg/node-fluent-ffmpeg#prerequisites

@acid-chicken
Copy link
Member

Dockerfile やその他ドキュメントの更新が必要ですね。

@syuilo
Copy link
Member

syuilo commented Feb 2, 2019

とりあえずffmpegが無くてもサムネイルが生成されないだけでファイルがアップロードできなくなったりはしなかったので破壊的変更ではなさそうですね

@syuilo syuilo merged commit 3040700 into misskey-dev:develop Feb 2, 2019
@syuilo
Copy link
Member

syuilo commented Feb 2, 2019

👍👍👍👍👍

@acid-chicken acid-chicken mentioned this pull request Feb 2, 2019
@mei23
Copy link
Contributor Author

mei23 commented Feb 2, 2019

TODO: アスペクト比を尊重する
TODO: png => jpeg

@mei23 mei23 mentioned this pull request Feb 2, 2019
@mei23 mei23 deleted the mei-90202-video-thumbs branch October 11, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants