Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4152 #4224

Merged
merged 3 commits into from
Feb 11, 2019
Merged

Fix #4152 #4224

merged 3 commits into from
Feb 11, 2019

Conversation

mei23
Copy link
Contributor

@mei23 mei23 commented Feb 11, 2019

Summary

Fix #4152
ドキュメントが参照できるようにしています

import * as locales from '../../../locales'; にすると以下のエラー出てしまうのでしてない

src/server/web/docs.ts(66,53): error TS7017: Element implicitly has an 'any' type because type 'typeof import("misskey/locales/index")' has no index signature.

@mei23 mei23 requested review from syuilo and acid-chicken February 11, 2019 10:41
@acid-chicken
Copy link
Member

型定義の方を

declare const locales: { [lang: string]: any };

export = locales;

などにすることで対応できませんか、すみません。

@mei23
Copy link
Contributor Author

mei23 commented Feb 11, 2019

@acid-chicken そうしました
ビルドエラーなし
ja-JP, en-US で各ページが閲覧できること確認済み

locales/index.d.ts Outdated Show resolved Hide resolved
@mei23
Copy link
Contributor Author

mei23 commented Feb 11, 2019

OKです

@acid-chicken
Copy link
Member

ありがとうございます。

@acid-chicken acid-chicken merged commit 2c1a7f4 into misskey-dev:develop Feb 11, 2019
@mei23 mei23 deleted the mei-90211-4152 branch July 21, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants