ファイルと画像認識処理の改善 #5690
Merged
ファイルと画像認識処理の改善 #5690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
tamaina
approved these changes
Jan 8, 2020
acid-chicken
reviewed
Jan 8, 2020
syuilo
reviewed
Jan 9, 2020
acid-chicken
reviewed
Jan 9, 2020
Co-Authored-By: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
|
CIうごいた |
acid-chicken
reviewed
Jan 9, 2020
Co-Authored-By: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
Co-Authored-By: Acid Chicken (硫酸鶏) <root@acid-chicken.com>
acid-chicken
reviewed
Jan 9, 2020
|
これで良さそうかな |
syuilo
approved these changes
Jan 10, 2020
acid-chicken
approved these changes
Jan 12, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #5674 とテスト追加とリファクタ
(これは対象にしてもリソース食うだけ食って結局コケる)
driver/add-fileの calcHash, getFileSize, avgColor などを getFileInfo にまとめる