Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): Vite related boot mechanism revision #8753

Merged
merged 4 commits into from
May 29, 2022

Conversation

tamaina
Copy link
Contributor

@tamaina tamaina commented May 28, 2022

#8752 の続き

What

Vite関連のブート機序の見直し

  • SSR view (pug) のCache-Control: max-ageを600秒(10分)から15秒にする。0秒にするべきかもしれないが、15sにしてみた。
    ちなみに、CloudflareのFreeプランでのキャッシュ最短時間は2時間。(なので、タダでCloudflareを使っている場合、もともとエッジキャッシュは効いていない。) https://developers.cloudflare.com/cache/about/edge-browser-cache-ttl/
  • app.hoge(hash).jsをmodulepreloadするように。Viteはファイル名にハッシュが含まれるため、saltは廃止した。
  • boot.jsのrenderErrorのエラー内容の表示はJSON.stringify()を使うように

Why

To improve user experience

Additional info (optional)

p1.a9z.devに適用中

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label May 28, 2022
@tamaina tamaina requested a review from syuilo May 28, 2022 21:52
@syuilo syuilo merged commit f1d2398 into misskey-dev:develop May 29, 2022
@syuilo
Copy link
Member

syuilo commented May 29, 2022

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants