chore(NA): upgrade typescript-eslint packages to v5.14.0 (elastic#127275

) * chore(NA): upgrade typescript-eslint packages to v5.14.0 * chore(NA): ignore required quotes * Update packages/elastic-eslint-config-kibana/typescript.js Co-authored-by: Spencer <email@spalger.com> * chore(NA): remove old lint disable comments Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Spencer <spencer@elastic.co> Co-authored-by: Spencer <email@spalger.com>
mistic · Mar 10, 2022 · 8cd75df · 8cd75df
1 parent c4a5a38
commit 8cd75df
Show file tree

Hide file tree

Showing 56 changed files with 67 additions and 146 deletions.
diff --git a/package.json b/package.json
@@ -719,9 +719,9 @@
     "@types/yargs": "^15.0.0",
     "@types/yauzl": "^2.9.1",
     "@types/zen-observable": "^0.8.0",
-    "@typescript-eslint/eslint-plugin": "^5.13.0",
-    "@typescript-eslint/parser": "^5.13.0",
-    "@typescript-eslint/typescript-estree": "^5.13.0",
+    "@typescript-eslint/eslint-plugin": "^5.14.0",
+    "@typescript-eslint/parser": "^5.14.0",
+    "@typescript-eslint/typescript-estree": "^5.14.0",
     "@yarnpkg/lockfile": "^1.1.0",
     "abab": "^2.0.4",
     "aggregate-error": "^3.1.0",

diff --git a/packages/elastic-eslint-config-kibana/typescript.js b/packages/elastic-eslint-config-kibana/typescript.js
@@ -168,6 +168,22 @@ module.exports = {
               selector: 'enum',
               format: ['PascalCase', 'UPPER_CASE', 'camelCase'],
             },
+            // https://typescript-eslint.io/rules/naming-convention/#ignore-properties-that-require-quotes
+            // restore check behavior before https://github.com/typescript-eslint/typescript-eslint/pull/4582
+            {
+              selector: [
+                'classProperty',
+                'objectLiteralProperty',
+                'typeProperty',
+                'classMethod',
+                'objectLiteralMethod',
+                'typeMethod',
+                'accessor',
+                'enumMember'
+              ],
+              format: null,
+              modifiers: ['requiresQuotes']
+            }
           ],
           '@typescript-eslint/explicit-member-accessibility': ['error',
             {

diff --git a/packages/kbn-telemetry-tools/src/tools/check_collector__integrity.test.ts b/packages/kbn-telemetry-tools/src/tools/check_collector__integrity.test.ts
@@ -78,7 +78,6 @@ describe('checkCompatibleTypeDescriptor', () => {
     ]);
     expect(incompatibles).toHaveLength(1);
     const { diff, message } = incompatibles[0];
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     expect(diff).toEqual({ '@@INDEX@@.count_2.kind': 'number' });
     expect(message).toHaveLength(1);
     expect(message).toEqual([

diff --git a/src/plugins/advanced_settings/public/management_app/components/field/field.tsx b/src/plugins/advanced_settings/public/management_app/components/field/field.tsx
@@ -616,9 +616,7 @@ export class Field extends PureComponent<FieldProps> {
     const isInvalid = unsavedChanges?.isInvalid;
 
     const className = classNames('mgtAdvancedSettings__field', {
-      // eslint-disable-next-line @typescript-eslint/naming-convention
       'mgtAdvancedSettings__field--unsaved': unsavedChanges,
-      // eslint-disable-next-line @typescript-eslint/naming-convention
       'mgtAdvancedSettings__field--invalid': isInvalid,
     });
     const groupId = `${setting.name}-group`;

diff --git a/src/plugins/chart_expressions/expression_metric/public/components/metric_value.tsx b/src/plugins/chart_expressions/expression_metric/public/components/metric_value.tsx
@@ -28,11 +28,8 @@ export const MetricVisValue = ({
   autoScale,
 }: MetricVisValueProps) => {
   const containerClassName = classNames('mtrVis__container', {
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     'mtrVis__container--light': metric.lightText,
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     'mtrVis__container-isfilterable': onFilter,
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     'mtrVis__container-isfull': !autoScale && colorFullBackground,
   });
 

diff --git a/src/plugins/charts/public/static/components/color_picker.tsx b/src/plugins/charts/public/static/components/color_picker.tsx
@@ -156,7 +156,6 @@ export const ColorPicker = ({
                 size="l"
                 color={selectedColor}
                 className={classNames('visColorPicker__valueDot', {
-                  // eslint-disable-next-line @typescript-eslint/naming-convention
                   'visColorPicker__valueDot-isSelected': color === selectedColor,
                 })}
                 style={{ color }}

diff --git a/src/plugins/charts/public/static/components/legend_toggle.tsx b/src/plugins/charts/public/static/components/legend_toggle.tsx
@@ -31,7 +31,6 @@ const LegendToggleComponent = ({ onClick, showLegend, legendPosition }: LegendTo
       color="text"
       onClick={onClick}
       className={classNames('echLegend__toggle', `echLegend__toggle--position-${legendPosition}`, {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         'echLegend__toggle--isOpen': showLegend,
       })}
       aria-label={i18n.translate('charts.legend.toggleLegendButtonAriaLabel', {

diff --git a/src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid_item.tsx b/src/plugins/dashboard/public/application/embeddable/grid/dashboard_grid_item.tsx
@@ -52,9 +52,7 @@ const Item = React.forwardRef<HTMLDivElement, Props>(
     const expandPanel = expandedPanelId !== undefined && expandedPanelId === id;
     const hidePanel = expandedPanelId !== undefined && expandedPanelId !== id;
     const classes = classNames({
-      // eslint-disable-next-line @typescript-eslint/naming-convention
       'dshDashboardGrid__item--expanded': expandPanel,
-      // eslint-disable-next-line @typescript-eslint/naming-convention
       'dshDashboardGrid__item--hidden': hidePanel,
       // eslint-disable-next-line @typescript-eslint/naming-convention
       printViewport__vis: container.getInput().viewMode === ViewMode.PRINT,

diff --git a/src/plugins/data/public/ui/query_string_input/query_bar_top_row.tsx b/src/plugins/data/public/ui/query_string_input/query_bar_top_row.tsx
@@ -284,7 +284,6 @@ export const QueryBarTopRow = React.memo(
       }
 
       const wrapperClasses = classNames('kbnQueryBar__datePickerWrapper', {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         'kbnQueryBar__datePickerWrapper-isHidden': isQueryInputFocused,
       });
 

diff --git a/src/plugins/data/public/ui/search_bar/search_bar.tsx b/src/plugins/data/public/ui/search_bar/search_bar.tsx
@@ -399,7 +399,6 @@ class SearchBarUI extends Component<SearchBarProps, State> {
     let filterBar;
     if (this.shouldRenderFilterBar()) {
       const filterGroupClasses = classNames('globalFilterGroup__wrapper', {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         'globalFilterGroup__wrapper-isVisible': this.state.isFiltersVisible,
       });
 

diff --git a/src/plugins/data_view_editor/public/components/flyout_panels/flyout_panel.tsx b/src/plugins/data_view_editor/public/components/flyout_panels/flyout_panel.tsx
@@ -51,15 +51,13 @@ export const Panel: React.FC<Props & React.HTMLProps<HTMLDivElement>> = ({
     hasFooter: false,
   });
 
-  /* eslint-disable @typescript-eslint/naming-convention */
   const classes = classnames('fieldEditor__flyoutPanel', className, {
     'fieldEditor__flyoutPanel--pageBackground': backgroundColor === 'euiPageBackground',
     'fieldEditor__flyoutPanel--emptyShade': backgroundColor === 'euiEmptyShade',
     'fieldEditor__flyoutPanel--leftBorder': border === 'left',
     'fieldEditor__flyoutPanel--rightBorder': border === 'right',
     'fieldEditor__flyoutPanel--withContent': config.hasContent,
   });
-  /* eslint-enable @typescript-eslint/naming-convention */
 
   const { addPanel } = useFlyoutPanelsContext();
 

diff --git a/src/plugins/data_view_field_editor/public/components/flyout_panels/flyout_panel.tsx b/src/plugins/data_view_field_editor/public/components/flyout_panels/flyout_panel.tsx
@@ -56,15 +56,13 @@ export const Panel: React.FC<Props & React.HTMLProps<HTMLDivElement>> = ({
 
   const [styles, setStyles] = useState<CSSProperties>({});
 
-  /* eslint-disable @typescript-eslint/naming-convention */
   const classes = classnames('fieldEditor__flyoutPanel', className, {
     'fieldEditor__flyoutPanel--pageBackground': backgroundColor === 'euiPageBackground',
     'fieldEditor__flyoutPanel--emptyShade': backgroundColor === 'euiEmptyShade',
     'fieldEditor__flyoutPanel--leftBorder': border === 'left',
     'fieldEditor__flyoutPanel--rightBorder': border === 'right',
     'fieldEditor__flyoutPanel--withContent': config.hasContent,
   });
-  /* eslint-enable @typescript-eslint/naming-convention */
 
   const { addPanel } = useFlyoutPanelsContext();
 

diff --git a/src/plugins/data_view_field_editor/public/components/preview/field_list/field_list_item.tsx b/src/plugins/data_view_field_editor/public/components/preview/field_list/field_list_item.tsx
@@ -42,12 +42,10 @@ export const PreviewListItem: React.FC<Props> = ({
 
   const [isPreviewImageModalVisible, setIsPreviewImageModalVisible] = useState(false);
 
-  /* eslint-disable @typescript-eslint/naming-convention */
   const classes = classnames('indexPatternFieldEditor__previewFieldList__item', {
     'indexPatternFieldEditor__previewFieldList__item--highlighted': isFromScript,
     'indexPatternFieldEditor__previewFieldList__item--pinned': isPinned,
   });
-  /* eslint-enable @typescript-eslint/naming-convention */
 
   const doesContainImage = formattedValue?.includes('<img');
 

diff --git a/src/plugins/discover/public/components/discover_grid/discover_grid_document_selection.tsx b/src/plugins/discover/public/components/discover_grid/discover_grid_document_selection.tsx
@@ -166,7 +166,6 @@ export function DiscoverGridDocumentToolbarBtn({
           className={classNames({
             // eslint-disable-next-line @typescript-eslint/naming-convention
             euiDataGrid__controlBtn: true,
-            // eslint-disable-next-line @typescript-eslint/naming-convention
             'euiDataGrid__controlBtn--active': isFilterActive,
           })}
         >

diff --git a/src/plugins/discover/public/components/doc_table/components/table_row.tsx b/src/plugins/discover/public/components/doc_table/components/table_row.tsx
@@ -57,7 +57,6 @@ export const TableRow = ({
   );
   const [open, setOpen] = useState(false);
   const docTableRowClassName = classNames('kbnDocTable__row', {
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     'kbnDocTable__row--highlight': row.isAnchor,
   });
   const anchorDocTableRowSubj = row.isAnchor ? ' docTableAnchorRow' : '';

diff --git a/src/plugins/embeddable/public/lib/panel/panel_header/panel_header.tsx b/src/plugins/embeddable/public/lib/panel/panel_header/panel_header.tsx
@@ -131,7 +131,6 @@ export function PanelHeader({
   const showPanelBar =
     !isViewMode || badges.length > 0 || notifications.length > 0 || showTitle || description;
   const classes = classNames('embPanel__header', {
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     'embPanel__header--floater': !showPanelBar,
   });
   const placeholderTitle = i18n.translate('embeddableApi.panel.placeholderTitle', {

diff --git a/src/plugins/kibana_react/public/code_editor/code_editor.tsx b/src/plugins/kibana_react/public/code_editor/code_editor.tsx
@@ -178,11 +178,9 @@ export const CodeEditor: React.FC<Props> = ({
 
   const [isHintActive, setIsHintActive] = useState(true);
 
-  /* eslint-disable @typescript-eslint/naming-convention */
   const promptClasses = classNames('kibanaCodeEditor__keyboardHint', {
     'kibanaCodeEditor__keyboardHint--isInactive': !isHintActive,
   });
-  /* eslint-enable  @typescript-eslint/naming-convention */
 
   const _updateDimensions = useCallback(() => {
     _editor.current?.layout();

diff --git a/src/plugins/kibana_react/public/page_template/with_solution_nav.tsx b/src/plugins/kibana_react/public/page_template/with_solution_nav.tsx
@@ -39,7 +39,6 @@ export const withSolutionNav = (WrappedComponent: ComponentType<KibanaPageTempla
     const sideBarClasses = classNames(
       'kbnPageTemplate__pageSideBar',
       {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         'kbnPageTemplate__pageSideBar--shrink':
           isMediumBreakpoint || (isLargerBreakpoint && !isSideNavOpenOnDesktop),
       },

diff --git a/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts b/src/plugins/kibana_usage_collection/server/collectors/management/schema.ts
@@ -176,7 +176,6 @@ export const stackManagementSchema: MakeSchemaFrom<UsageStats> = {
     type: 'boolean',
     _meta: { description: 'Non-default value of setting.' },
   },
-  // eslint-disable-next-line @typescript-eslint/naming-convention
   'doc_table:hideTimeColumn': {
     type: 'boolean',
     _meta: { description: 'Non-default value of setting.' },

diff --git a/src/plugins/kibana_usage_collection/server/collectors/management/types.ts b/src/plugins/kibana_usage_collection/server/collectors/management/types.ts
@@ -73,7 +73,6 @@ export interface UsageStats {
   'notifications:lifetime:error': number;
   'doc_table:highlight': boolean;
   'discover:searchOnPageLoad': boolean;
-  // eslint-disable-next-line @typescript-eslint/naming-convention
   'doc_table:hideTimeColumn': boolean;
   'discover:sampleSize': number;
   defaultColumns: string[];

diff --git a/src/plugins/vis_types/vislib/public/vislib/components/legend/legend.tsx b/src/plugins/vis_types/vislib/public/vislib/components/legend/legend.tsx
@@ -263,7 +263,6 @@ export class VisLegend extends PureComponent<VisLegendProps, VisLegendState> {
           type="button"
           onClick={this.toggleLegend}
           className={classNames('visLegend__toggle kbn-resetFocusState', {
-            // eslint-disable-next-line @typescript-eslint/naming-convention
             'visLegend__toggle--isOpen': open,
           })}
           aria-label={i18n.translate('visTypeVislib.vislib.legend.toggleLegendButtonAriaLabel', {

diff --git a/...blic/application/common/components/stats_table/components/field_data_row/column_chart.tsx b/...blic/application/common/components/stats_table/components/field_data_row/column_chart.tsx
@@ -72,7 +72,6 @@ export const ColumnChart: FC<Props> = ({
       )}
       <div
         className={classNames('dataGridChart__legend', {
-          // eslint-disable-next-line @typescript-eslint/naming-convention
           'dataGridChart__legend--numeric': columnType.schema === 'number',
         })}
         data-test-subj={`${dataTestSubj}-legend`}

diff --git a/x-pack/plugins/graph/public/components/field_manager/field_editor.tsx b/x-pack/plugins/graph/public/components/field_manager/field_editor.tsx
@@ -133,7 +133,6 @@ export function FieldEditor({
           color={initialField.color}
           iconSide="right"
           className={classNames('gphFieldEditor__badge', {
-            // eslint-disable-next-line @typescript-eslint/naming-convention
             'gphFieldEditor__badge--disabled': isDisabled,
           })}
           onClickAriaLabel={badgeDescription}

diff --git a/x-pack/plugins/graph/public/components/field_manager/field_picker.tsx b/x-pack/plugins/graph/public/components/field_manager/field_picker.tsx
@@ -56,7 +56,6 @@ export function FieldPicker({
         <EuiBadge
           data-test-subj="graph-add-field-button"
           className={classNames('gphFieldPicker__button', {
-            // eslint-disable-next-line @typescript-eslint/naming-convention
             'gphFieldPicker__button--disabled': !hasFields,
           })}
           color="hollow"

diff --git a/x-pack/plugins/graph/public/components/graph_visualization/graph_visualization.tsx b/x-pack/plugins/graph/public/components/graph_visualization/graph_visualization.tsx
@@ -147,15 +147,13 @@ export function GraphVisualization({
                   cy={node.ky}
                   r={node.scaledSize}
                   className={classNames('gphNode__circle', {
-                    // eslint-disable-next-line @typescript-eslint/naming-convention
                     'gphNode__circle--selected': node.isSelected,
                   })}
                   style={{ fill: node.color }}
                 />
                 {node.icon && (
                   <text
                     className={classNames('fa gphNode__text', {
-                      // eslint-disable-next-line @typescript-eslint/naming-convention
                       'gphNode__text--inverse': isColorDark(...hexToRgb(node.color)),
                     })}
                     transform="translate(0,5)"

diff --git a/x-pack/plugins/graph/public/components/guidance_panel/guidance_panel.tsx b/x-pack/plugins/graph/public/components/guidance_panel/guidance_panel.tsx
@@ -53,7 +53,6 @@ function ListItem({
     // eslint-disable-next-line jsx-a11y/role-supports-aria-props
     <li
       className={classNames('gphGuidancePanel__item', {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         'gphGuidancePanel__item--disabled': state === 'disabled',
       })}
       aria-disabled={state === 'disabled'}
@@ -62,7 +61,6 @@ function ListItem({
       {state !== 'disabled' && (
         <span
           className={classNames('gphGuidancePanel__itemIcon', {
-            // eslint-disable-next-line @typescript-eslint/naming-convention
             'gphGuidancePanel__itemIcon--done': state === 'done',
           })}
           aria-hidden={true}

diff --git a/x-pack/plugins/graph/public/components/settings/url_template_form.tsx b/x-pack/plugins/graph/public/components/settings/url_template_form.tsx
@@ -129,7 +129,6 @@ export function UrlTemplateForm(props: UrlTemplateFormProps) {
         props.initialTemplate.icon && <LegacyIcon asListIcon icon={props.initialTemplate.icon} />
       }
       className={classNames('gphUrlTemplateList__accordion', {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         'gphUrlTemplateList__accordion--isOpen': open,
       })}
       buttonClassName="gphUrlTemplateList__accordionbutton"

diff --git a/...cation/components/component_templates/component_template_selector/component_templates.tsx b/...cation/components/component_templates/component_template_selector/component_templates.tsx
@@ -175,7 +175,6 @@ export const ComponentTemplates = ({ isLoading, components, listItemProps }: Pro
       </div>
       <div
         className={classNames('eui-yScrollWithShadows componentTemplates__listWrapper', {
-          // eslint-disable-next-line @typescript-eslint/naming-convention
           'componentTemplates__listWrapper--is-empty': isSearchResultEmpty,
         })}
       >

diff --git a/...mponents/component_templates/component_template_selector/component_templates_selector.tsx b/...mponents/component_templates/component_template_selector/component_templates_selector.tsx
@@ -156,7 +156,6 @@ export const ComponentTemplatesSelector = ({
       {/* Selection */}
       <EuiFlexItem
         className={classNames('componentTemplatesSelector__selection', {
-          // eslint-disable-next-line @typescript-eslint/naming-convention
           'componentTemplatesSelector__selection--is-empty': !hasSelection,
         })}
         data-test-subj="componentTemplatesSelection"

diff --git a/...omponents/mappings_editor/components/document_fields/fields/create_field/create_field.tsx b/...omponents/mappings_editor/components/document_fields/fields/create_field/create_field.tsx
@@ -175,10 +175,8 @@ export const CreateField = React.memo(function CreateFieldComponent({
       >
         <div
           className={classNames('mappingsEditor__createFieldWrapper', {
-            // eslint-disable-next-line @typescript-eslint/naming-convention
             'mappingsEditor__createFieldWrapper--toggle':
               Boolean(maxNestedDepth) && maxNestedDepth! > 0,
-            // eslint-disable-next-line @typescript-eslint/naming-convention
             'mappingsEditor__createFieldWrapper--multiField': isMultiField,
           })}
           style={{

diff --git a/...ication/components/mappings_editor/components/document_fields/fields/fields_list_item.tsx b/...ication/components/mappings_editor/components/document_fields/fields/fields_list_item.tsx
@@ -197,7 +197,6 @@ function FieldListItemComponent(
   return (
     <li
       className={classNames('mappingsEditor__fieldsListItem', {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         'mappingsEditor__fieldsListItem--dottedLine': hasDottedLine,
       })}
       data-test-subj={`fieldsListItem ${dataTestSubj}`}
@@ -206,17 +205,13 @@ function FieldListItemComponent(
       <div
         style={{ paddingLeft: `${indent}px` }}
         className={classNames('mappingsEditor__fieldsListItem__field', {
-          // eslint-disable-next-line @typescript-eslint/naming-convention
           'mappingsEditor__fieldsListItem__field--enabled': areActionButtonsVisible,
-          // eslint-disable-next-line @typescript-eslint/naming-convention
           'mappingsEditor__fieldsListItem__field--highlighted': isHighlighted,
-          // eslint-disable-next-line @typescript-eslint/naming-convention
           'mappingsEditor__fieldsListItem__field--dim': isDimmed,
         })}
       >
         <div
           className={classNames('mappingsEditor__fieldsListItem__wrapper', {
-            // eslint-disable-next-line @typescript-eslint/naming-convention
             'mappingsEditor__fieldsListItem__wrapper--indent':
               treeDepth === 0 && maxNestedDepth === 0,
           })}
@@ -225,11 +220,8 @@ function FieldListItemComponent(
             gutterSize="s"
             alignItems="center"
             className={classNames('mappingsEditor__fieldsListItem__content', {
-              // eslint-disable-next-line @typescript-eslint/naming-convention
               'mappingsEditor__fieldsListItem__content--toggle': hasChildFields || hasMultiFields,
-              // eslint-disable-next-line @typescript-eslint/naming-convention
               'mappingsEditor__fieldsListItem__content--multiField': isMultiField,
-              // eslint-disable-next-line @typescript-eslint/naming-convention
               'mappingsEditor__fieldsListItem__content--indent':
                 !hasChildFields && !hasMultiFields && maxNestedDepth > treeDepth,
             })}

diff --git a/...omponents/mappings_editor/components/document_fields/search_fields/search_result_item.tsx b/...omponents/mappings_editor/components/document_fields/search_fields/search_result_item.tsx
@@ -91,11 +91,8 @@ export const SearchResultItem = React.memo(function FieldListItemFlatComponent({
     <div className={classNames('mappingsEditor__fieldsListItem')} data-test-subj="fieldsListItem">
       <div
         className={classNames('mappingsEditor__fieldsListItem__field', {
-          // eslint-disable-next-line @typescript-eslint/naming-convention
           'mappingsEditor__fieldsListItem__field--enabled': areActionButtonsVisible,
-          // eslint-disable-next-line @typescript-eslint/naming-convention
           'mappingsEditor__fieldsListItem__field--selected': isHighlighted,
-          // eslint-disable-next-line @typescript-eslint/naming-convention
           'mappingsEditor__fieldsListItem__field--dim': isDimmed,
         })}
       >
@@ -104,9 +101,7 @@ export const SearchResultItem = React.memo(function FieldListItemFlatComponent({
             gutterSize="s"
             alignItems="center"
             className={classNames('mappingsEditor__fieldsListItem__content', {
-              // eslint-disable-next-line @typescript-eslint/naming-convention
               'mappingsEditor__fieldsListItem__content--toggle': hasChildFields || hasMultiFields,
-              // eslint-disable-next-line @typescript-eslint/naming-convention
               'mappingsEditor__fieldsListItem__content--multiField': isMultiField,
             })}
           >

diff --git a/...lication/components/mappings_editor/components/runtime_fields/runtimefields_list_item.tsx b/...lication/components/mappings_editor/components/runtime_fields/runtimefields_list_item.tsx
@@ -84,11 +84,8 @@ function RuntimeFieldsListItemComponent(
     <li className="mappingsEditor__fieldsListItem" data-test-subj="runtimeFieldsListItem">
       <div
         className={classNames('mappingsEditor__fieldsListItem__field', {
-          // eslint-disable-next-line @typescript-eslint/naming-convention
           'mappingsEditor__fieldsListItem__field--enabled': areActionButtonsVisible,
-          // eslint-disable-next-line @typescript-eslint/naming-convention
           'mappingsEditor__fieldsListItem__field--highlighted': isHighlighted,
-          // eslint-disable-next-line @typescript-eslint/naming-convention
           'mappingsEditor__fieldsListItem__field--dim': isDimmed,
         })}
       >

diff --git a/...on/components/pipeline_editor/components/pipeline_processors_editor_item/context_menu.tsx b/...on/components/pipeline_editor/components/pipeline_processors_editor_item/context_menu.tsx
@@ -27,7 +27,6 @@ export const ContextMenu: FunctionComponent<Props> = (props) => {
   const [isOpen, setIsOpen] = useState<boolean>(false);
 
   const containerClasses = classNames({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     'pipelineProcessorsEditor__item--displayNone': hidden,
   });
 

diff --git a/...mponents/pipeline_editor/components/pipeline_processors_editor_item/inline_text_input.tsx b/...mponents/pipeline_editor/components/pipeline_processors_editor_item/inline_text_input.tsx
@@ -36,7 +36,6 @@ function _InlineTextInput({
   const [textValue, setTextValue] = useState<string>(() => text ?? '');
 
   const containerClasses = classNames('pipelineProcessorsEditor__item__textContainer', {
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     'pipelineProcessorsEditor__item__textContainer--notEditing': !isShowingTextInput && !disabled,
   });