Fix GetProperty always returning 'VALUE' #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mikudeko thanks for the PR, it looks good but I want to refresh tests / travis before merging. I'm in the process of that right now and will ping you once that lands. You will then be able to rebase on master and we can ensure travis is green before merging. |
|
hey @mikudeko can you rebase on top of master and fix the test so that it passes with your changes? Thanks |
simt2
force-pushed
the
master
branch
2 times, most recently
from
c940b84
to
46d75e6
Compare
|
hey @mmlb , I think you can merge this now. Thanks! |
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Apr 14, 2019
full diff: mistifyio/go-zfs@22c9b32...f784269 relevant changes: - mistifyio/go-zfs#50 Fix GetProperty always returning 'VALUE' - fixes mistifyio/go-zfs#49 dataset.GetProperty(key) always returns 'VALUE' - mistifyio/go-zfs#53 Fix parseLine for fragmentation field - fixes mistifyio/go-zfs#52 setUint receives empty string for fragmentation in some cases - mistifyio/go-zfs#54 Add 'referenced' to zfs properties - mistifyio/go-zfs#72 Switch to google/uuid - removes the github.com/pborman/uuid dependency Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Apr 16, 2019
full diff: mistifyio/go-zfs@22c9b32...f784269 relevant changes: - mistifyio/go-zfs#50 Fix GetProperty always returning 'VALUE' - fixes mistifyio/go-zfs#49 dataset.GetProperty(key) always returns 'VALUE' - mistifyio/go-zfs#53 Fix parseLine for fragmentation field - fixes mistifyio/go-zfs#52 setUint receives empty string for fragmentation in some cases - mistifyio/go-zfs#54 Add 'referenced' to zfs properties - mistifyio/go-zfs#72 Switch to google/uuid - removes the github.com/pborman/uuid dependency Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 179d51ba984508a9cec5756cb56a67f17dd6f435 Component: engine
kiku-jw
pushed a commit
to kiku-jw/moby
that referenced
this pull request
May 16, 2019
full diff: mistifyio/go-zfs@22c9b32...f784269 relevant changes: - mistifyio/go-zfs#50 Fix GetProperty always returning 'VALUE' - fixes mistifyio/go-zfs#49 dataset.GetProperty(key) always returns 'VALUE' - mistifyio/go-zfs#53 Fix parseLine for fragmentation field - fixes mistifyio/go-zfs#52 setUint receives empty string for fragmentation in some cases - mistifyio/go-zfs#54 Add 'referenced' to zfs properties - mistifyio/go-zfs#72 Switch to google/uuid - removes the github.com/pborman/uuid dependency Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.