Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Level transition and Fixed Gmod crashing. #199

Closed
wants to merge 4 commits into from
Closed

Fixed Level transition and Fixed Gmod crashing. #199

wants to merge 4 commits into from

Conversation

RaphaelIT7
Copy link
Contributor

@RaphaelIT7 RaphaelIT7 commented Oct 26, 2023 •
edited
Loading

[#] Fixed a crash in Gmod related to ConVars (Thanks to Rubat who helped me find the approximate cause of the crash)

I don't exactly know why the removed delete statements crashed the game (HL2), but they did.

Related Issues:
fixes #166
fixes #155
fixes #60

ToDo:

@RaphaelIT7
Fixed some crashes.
813dbf7 
For some reason, it crashes at these points.
There should be a reason for it but idk.
There also should be a better way to solve this.
@RaphaelIT7
Workaround for Gmod ConVars causing a crash
1d4db16
@RaphaelIT7 RaphaelIT7 marked this pull request as draft October 27, 2023 16:41
@RaphaelIT7 RaphaelIT7 changed the title Fixed Level transition and added a Workaround for Gmod crashing. Fixed Level transition and Fixed Gmod crashing. Dec 14, 2023
@RaphaelIT7 RaphaelIT7 marked this pull request as ready for review December 14, 2023 23:35
@NathanX-S
Copy link

Is this repository being managed at all or should it be forked/handed off to a new maintainer..? @Joshua-Ashton

@misyltoad
Copy link
Owner

This MR does nothing. It just adds a bunch of ifdefs around code that was already compiled for Garry's Mod.

image

@RaphaelIT7
Copy link
Contributor Author

Coming back to this, this looks more like a workaround instead of an actual fix, so I'm closing this for now.
Maybe I'll come back to this later and try to fix it properly

@RaphaelIT7 RaphaelIT7 closed this Jul 28, 2024
@misyltoad
Copy link
Owner

It doesn't work around anything though. GAME_GMOD is always defined for... gmod.

@RaphaelIT7
Copy link
Contributor Author

With workaround, I mean these delete changes.
Only deleting stuff in Gmod doesn't seem like a proper solution to solve the crashes that I had in HL2.
The PR to stop the ConVars from crashing should have solved #60 and #166 and these delete changes should solve #155, but I don't think that this is really the solution for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GMod x64] Crashing on legacy HL2 saving/changelevels Crash on levelchange [GMOD] Server crash
3 participants
@RaphaelIT7 @NathanX-S @misyltoad