Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating ubuntu to version 22.04+ in github workflows; fixes #266 #274

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

rockett-m
Copy link
Contributor

@rockett-m rockett-m commented Jun 26, 2024

Updated ubuntu 20.04 to 22.04 in github workflows.

Many of the gh actions are deprecated so they need updates for ubuntu 22.04+ to work.

gh warnings

@rockett-m rockett-m marked this pull request as ready for review June 26, 2024 20:09
@rockett-m rockett-m force-pushed the ubuntu-22.04 branch 10 times, most recently from 4417590 to 33069f8 Compare June 27, 2024 15:56
@rockett-m rockett-m force-pushed the ubuntu-22.04 branch 3 times, most recently from b1396e7 to f3b2d81 Compare July 24, 2024 19:21
@rockett-m
Copy link
Contributor Author

rockett-m commented Jul 24, 2024

[edit ignore this - local clang issues resolved]

Before squash at the end, will have separate commits as many file changes are needed

  • pure 20.04 to 22.04 gh workflow change and .cache/ added to .gitignore to avoid tracking clang created files
  • clang format fixes for lint.sh
  • manual code fixes to be c++ 20 compliant for lint.sh

@rockett-m rockett-m force-pushed the ubuntu-22.04 branch 2 times, most recently from 6c3fc8c to 0448f6a Compare July 29, 2024 22:16
Signed-off-by: Morgan Rockett <morgan.rockett@tufts.edu>
@rockett-m
Copy link
Contributor Author

@HalosGhost ready for review

Work done

  • updated remaining gh workflows at ubuntu version 20.04 to 22.04
  • updated gh workflow actions to latest integer release versions
  • fixed lint error to get ci::lint passing

Speedups

  • 500% stage speedup on 'CI / doxygen (pull_request)'
  • 10% stage speedup on 'CI / Unit and Integration Tests (pull_request)'
  • 5% stage speedup on 'CI / Build Release Candidate (pull_request)'

@HalosGhost
Copy link
Collaborator

Just double-checking: this does not include fixes for act for local testing right? So, this is purely a freshening of the versions (both container image and actions) in the CI?

@rockett-m
Copy link
Contributor Author

@HalosGhost correct

Copy link
Collaborator

@HalosGhost HalosGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ut-ACK (unable to test locally due to act still failing). This looks like a simple version upgrade (both github actions versions and container image versions), along with the one linting fix required by those same changes.

Looks good to me.

@HalosGhost HalosGhost merged commit 30797cb into mit-dci:trunk Jul 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants