-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement some much-needed improvements for the UHS load-generators #280
base: trunk
Are you sure you want to change the base?
Conversation
7c32062
to
4c60e65
Compare
@maurermi, this doesn't yet include the atomizer updates; but I'd love a review before I dive into that side. The types and configuration have been modified to mirror the exact current behavior of the test controller (so any currently deployed test controller should be able to now leverage targeted-load schedules in 2PC with no redeployment). Let me know if you want our TC spun up at any point this next week to give a t-ACK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
T-ACK. Confirmed that these changes work locally for allowing the 2PC-loadgen to ramp up its workload as specified. There is a noticeable load "spike" at the beginning of the test that we will need to address (as discussed out of band) but as this stands it is a significant improvement to the 2PC load generator that can be used as it stands.
(pulled to draft as I implement equivalent changes for the atomizer) |
This sets up the 2PC load-generator to read the config values the Test Controller already supports* to limit throughput to a set amount, optionally increasing it according to a definable schedule. Among other benefits, this allows the tester to constrain load-generators directly rather than by relying on the preseed count to artifically reduce their load. This also includes the relevant config changes to enable respected per-loadgen log-levels. Signed-off-by: Sam Stuewe <stuewe@mit.edu>
Signed-off-by: Sam Stuewe <stuewe@mit.edu>
Signed-off-by: Sam Stuewe <stuewe@mit.edu>
Signed-off-by: Sam Stuewe <stuewe@mit.edu>
19998dd
to
cd412ed
Compare
This first commit brings targeted-load for the 2PC load-gen; another commit will follow updating the atomizer load-gen as well.
cf. #279
I've been locally testing using variants of the configuration below:
Configuration