-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: get docker merge passing; fixes #283 #285
Conversation
rockett-m
commented
Jul 18, 2024
•
edited
Loading
edited
@HalosGhost and/or @maurermi would you be able to review this? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UT-ACK. This looks correct, will give it a test shortly, but I have high confidence. Thanks for patching this quickly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feedback updated
I will remove the additional docker-merge run on pull-request when we are good on the changes pre-merge
docker-build.sh runs successfully on ubuntu 22.04 disk image with these changes fyi
2834d46
to
07c1262
Compare
Signed-off-by: Morgan Rockett <morgan.rockett@tufts.edu>
Just ran and 8/8 checks passed. I had the docker merge stage included to see if it would pass. I have now removed just the docker-merge on pull-request and re-pushed the commit. Should be good to go now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in a seemingly related issue act
is now broken testing against trunk
, so I cannot reproduce this working locally; however, I saw the passing CI test, and I see that the push
workflow finished correctly on your fork. I'll merge this in-hopes that it solves the immediate CI/CD problem, but a fix to generally narrow the gap between pull
and merge
docker workflows, ideally also fixing act
for testing will be much appreciated.