fix: include the prefix directory in .dockerignore #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed on macOS that ./scripts/build-docker.sh was failing. Our Dockerfile runs ./scripts/setup-dependencies.sh in the container before running `COPY . .`, which if prefix/ is not ignored, will copy in the libraries built on the host. Signed-off-by: Michael Maurer <maurer.mi@northeastern.edu>
|
TACK - this worked for me running on mac and ubuntu |
|
@eolesinski I'd appreciate another macOS sign-off/review if you have the time (I don't have an easy way to give a t-ACK here). |
eolesinski
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
t-ACK - this change successfully fixes the error that was occurring when running the build-docker.sh script
Tested by running build-docker.sh before this change and encountered an error. Pulled in the changes from this PR and reran the build-docker.sh and it worked.
HalosGhost
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed on macOS that ./scripts/build-docker.sh was failing. Our Dockerfile runs ./scripts/setup-dependencies.sh in the container before running
COPY . ., which if prefix/ is not ignored, will copy in the libraries built on the host.