added timeout to raft initialization #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolesinski
force-pushed
the
add-raft-timeout
branch
from
19d9292
to
c7bab7e
Compare
Signed-off-by: eolesinski <eo2454@columbia.edu> Co-authored-by: Michael Maurer <maurer.mi@northeastern.edu>
eolesinski
force-pushed
the
add-raft-timeout
branch
from
c7bab7e
to
18b239e
Compare
3 tasks
maurermi
reviewed
Jul 25, 2024
There was a problem hiding this comment.
I can confirm that these changes fix the hanging test on MacOS, though I will refrain from giving this an approving review as I was heavily involved in developing this PR -- @HalosGhost it would be awesome if you could read this over and give a sanity check, and feel free to let me know if there are additional tests worth running on a Mac to verify this result.
Hopefully this change allows us to proceed with #263
HalosGhost
approved these changes
Jul 25, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #281 by adding a timeout to the raft initialization in
node.cppTested: tested by running
scripts/test.shand verified thatbasic_raft_cluster_failure_testno longer hangs.