Convert assert in create into a warning #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HalosGhost This should fix the error we discussed on a call last Friday |
maurermi
force-pushed
the
remove-assert-in-create
branch
from
bb1814a
to
6923b60
Compare
Turn the assert statement in create into a warning, this restores the ability to import tokens through Metamask. Details: When importing tokens, Metamask sends a create call without sender information, triggering an assert failure. Signed-off-by: Michael Maurer <maurer.mi@northeastern.edu>
maurermi
force-pushed
the
remove-assert-in-create
branch
from
6923b60
to
b4a1313
Compare
HalosGhost
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn the assert statement in create into a warning, this restores the ability to import tokens through Metamask.
Details: When importing tokens, Metamask sends a create call without sender information, triggering an assert failure.