-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verifying Example Functionality in GitHub Actions #206
Verifying Example Functionality in GitHub Actions #206
Conversation
As I’m working through this, noting examples I haven’t added: Depends on IBMQ Account:
Bugs (denoting ** for quick fixes in another pass-through):
Edits Needed before I can integrate:
|
@@ -305,12 +305,11 @@ def main(): | |||
model.set_qiskit_processor(processor_simulation) | |||
valid_test(dataflow, q_device, "test", model, device, qiskit=True) | |||
|
|||
# final valid | |||
valid_test(dataflow, q_device, "valid", model, device, True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: originally, this would raise an error since outside of the try/except, qiskit hasn’t been imported. I made the choice to move it inside the try so we don’t have to worry about the qiskit dependency if a user just wants to run it with pure TQ.
@@ -51,6 +51,7 @@ | |||
"CXCXCXLayer", | |||
"SWAPSWAPLayer", | |||
"RXYZCXLayer0", | |||
"U3CU3Layer0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that all in layers.py appears not to have all of the layers which was causing errors for one of the examples. I fixed the layer needed for the example but haven’t added all the layers yet since we will reformat the layers shortly and that can be done then. For now, just an FYI that not all the layers are in all at the moment.
@@ -25,3 +25,4 @@ | |||
from .vqe import * | |||
from .hamiltonian import * | |||
from .qft import * | |||
from .grover import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main fix is just adding this import; it must’ve gotten lost somehow when merging everything.
Fixed all of the smaller bugs. This is an updated list of all of the scripts I haven’t yet added to the workflow with some notes. Bugs:
Edits Needed before I can integrate:
Needs CUDA:
Depends on IBMQ Account:
|
Merging Dev to Get Latest Updates (Esp. with Isometry)
[minor] Reformat Tests
Looks like 3.12 is failing because one of the qiskit dependencies (disutils) is fully removed as of Python 3.12. There exists workarounds, but I expect the update should be pushed soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed
7dd04de
to
43b4712
Compare
Test Updates + Bug Fixes (Updated Version of #206)
Adding a feature which, along with running the tests, runs some examples. If we make some sort of breaking change that causes the examples to throw an error, we will be notified of it.
Currently just has the qubit-rotation, and I'll add some more which are compatible (for example, mnist isn't compatible at the moment since it uses IBMQ credentials).