Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rely on upstreamed Ltac2 functions (prompted by coq/coq#18973). #155

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Rely on upstreamed Ltac2 functions (prompted by coq/coq#18973). #155

merged 1 commit into from
Jun 4, 2024

Conversation

rlepigre
Copy link
Contributor

@rlepigre rlepigre commented Jun 3, 2024

No description provided.

JasonGross
JasonGross requested changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@JasonGross JasonGross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of these iter functions have been upstreamed into Coq itself, so we should be able to just remove them

@rlepigre rlepigre mentioned this pull request Jun 3, 2024
Merged
4 tasks
@rlepigre
Copy link
Contributor Author

rlepigre commented Jun 3, 2024

Both of these iter functions have been upstreamed into Coq itself, so we should be able to just remove them

Indeed, up to a small API change for the second function. So, I guess this can be merged directly?

@rlepigre rlepigre changed the title Adapt to coq/coq#18973. Rely on upstreamed Ltac2 functions (prompted by coq/coq#18973). Jun 3, 2024
@JasonGross JasonGross merged commit edcec73 into mit-plv:master Jun 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonGross JasonGross JasonGross requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rlepigre @JasonGross