This repository has been archived by the owner on Dec 19, 2017. It is now read-only.
add DeleteTags function #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase this against master? May be a good opportunity to add tests too, let me know if my other comment was clear enough in defining how to do that. |
deoxxa
force-pushed
the
add-delete-tags
branch
from
4d641bd to
cedd03c
Compare
|
I've rebased this, but I've got so little time to work on this kind of thing (as I'm no longer being paid for it) that I probably won't be able to write tests for it, unless it's incredibly simple to do so. I'll check and get back to you on it. |
|
Whoops, I totally did this on my own without seeing this PR. Sorry! On the bright side, it looks like we coded the EXACT same thing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says. Easy peasy.