Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix np 2.0 #1308

Merged
merged 31 commits into from
Jun 29, 2024
Merged

Fix np 2.0 #1308

merged 31 commits into from
Jun 29, 2024

Conversation

naterush
Copy link
Contributor

Description

np.NaN was removed in numpy 2.0, which was released this week. So this fixes that.

Testing

Use it.

Documentation

No.

aarondr77 and others added 28 commits March 14, 2024 20:08
Attempt to make prerelease tests less flaky
trymito: apply syntax highlighting to install commands
…-glossary

Remove typeform excel to python glossary
trymito: add pyoneer promotion to website
Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 11:06pm

@naterush naterush changed the base branch from dev to main June 20, 2024 16:54
@aarondr77
Copy link
Member

LGTM once tests pass

@naterush
Copy link
Contributor Author

Ok, all of these tests failures are bunk as far as I can tell:

  1. The installation I skipped is just a pandas importing issue, nothing to do with us / these changes:
mitosheet/__init__.py:27: in <module>
    import pandas as pd
/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/pandas/__init__.py:22: in <module>
    from pandas.compat import (
/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/pandas/compat/__init__.py:15: in <module>
    from pandas.compat.numpy import (
/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/pandas/compat/numpy/__init__.py:7: in <module>
    from pandas.util.version import Version
/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/pandas/util/__init__.py:1: in <module>
    from pandas.util._decorators import (  # noqa
/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/pandas/util/_decorators.py:14: in <module>
    from pandas._libs.properties import cache_readonly  # noqa
/opt/hostedtoolcache/Python/3.11.9/x64/lib/python3.11/site-packages/pandas/_libs/__init__.py:13: in <module>
    from pandas._libs.interval import Interval
pandas/_libs/interval.pyx:1: in init pandas._libs.interval
    ???
E   ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject
  1. The prerelease tests just mean we need to merge this into dev. I'll update the branch to do this.
  2. The pytests failing are a function of some snowflake change. I updated this and it should pass.
  3. There's a Firefox test failing due to flakiness.

Once the two failing tests pass, I'm gonna merge. Everything else is legit.

@naterush
Copy link
Contributor Author

Ok, just one flakey test. Merging.

@naterush naterush changed the base branch from main to dev June 29, 2024 00:53
@naterush naterush merged commit 6d3f898 into dev Jun 29, 2024
60 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants