Use first and last name fields for user #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ahmed-arb looks good please squash commits while merging. |
ahmed-arb
added a commit
that referenced
this pull request
Oct 25, 2023
* feat: Add GA 4 support to edX platform feat: add a snippet to public_video_share_embed.html feat: add google_analytics_4_id template tag for main_django.html fix: add js_escaped_string filter for ga_4_id * removed extra file public_video_share_embed.html * Use first and last name fields for user (#311) * feat: ask first and last name on account creation * feat: add first and last name in sysadmin report * feat: add first and last name in accounts page --------- Co-authored-by: Sagirov Eugeniy <sagirov19@gmail.com> Co-authored-by: Zain Virk <zain.virk@edly.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes signup form to take first and last name instead of full name. The signup form will look like this:
Instead of
And if users want to change their name afterwards accounts settings page will be changed to take first and last name separately as well:
Additionally,
sysadminreport, Download list of all users, will be changed to have first and last name.