Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support for Django 2.0+ #4

Merged
merged 1 commit into from
Jul 17, 2018
Merged

Conversation

amir-qayyum-khan
Copy link

@amir-qayyum-khan amir-qayyum-khan commented Jul 16, 2018

What are the relevant tickets?

fixes #3

What's this PR do?

It fix ForeignKey which requires 2 parameter from Django 2.0. But before that only one param was mandatory

How should this be manually tested?

Run migration with Django 2.0

@pdpinch

Note: open it upsteam

Copy link
Member

@mbertrand mbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also increment the version number too, in dj_elastictranscoder/__init__.py, to 0.9.7? Then one of us can create a tag/release for that after it's merged. Otherwise looks great!

@amir-qayyum-khan
Copy link
Author

Done @mbertrand

Copy link
Member

@mbertrand mbertrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting conflict with Django==2.0.7
2 participants