[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

authentication/middleware.py

@@ -31,6 +31,6 @@ def process_exception(self, request, exception):
 
             if url:  # noqa: RET503
                 url += (
-                    "?" in url and "&" or "?"
+                    ("?" in url and "&") or "?"
                 ) + f"message={quote(message)}&backend={backend_name}"
                 return redirect(url)

authentication/pipeline/user_test.py

@@ -64,7 +64,7 @@ def mock_create_user_strategy(mocker):
 
 
 @pytest.fixture
-def application(settings):  # noqa: PT004
+def application(settings):
     """Test data and settings needed for create_edx_user tests"""
     settings.OPENEDX_API_BASE_URL = "http://example.com"
 

conftest.py

@@ -9,7 +9,7 @@
 
 
 @pytest.fixture(autouse=True)
-def default_settings(monkeypatch, settings):  # noqa: PT004
+def default_settings(monkeypatch, settings):
     """Set default settings for all tests"""
     monkeypatch.setenv("DJANGO_SETTINGS_MODULE", "main.settings")
 
@@ -18,7 +18,7 @@ def default_settings(monkeypatch, settings):  # noqa: PT004
 
 
 @pytest.fixture(autouse=True)
-def mocked_product_signal(mocker):  # noqa: PT004
+def mocked_product_signal(mocker):
     """Mock hubspot_sync signals"""
     mocker.patch("ecommerce.signals.sync_hubspot_product")
 

ecommerce/api_test.py

@@ -110,7 +110,7 @@ def user(db):
 
 
 @pytest.fixture(autouse=True)
-def payment_gateway_settings():  # noqa: PT004
+def payment_gateway_settings():
     settings.MITOL_PAYMENT_GATEWAY_CYBERSOURCE_SECURITY_KEY = "Test Security Key"
     settings.MITOL_PAYMENT_GATEWAY_CYBERSOURCE_ACCESS_KEY = "Test Access Key"
     settings.MITOL_PAYMENT_GATEWAY_CYBERSOURCE_PROFILE_ID = uuid.uuid4()

ecommerce/views_test.py

@@ -80,7 +80,7 @@ def user(db):
 
 
 @pytest.fixture(autouse=True)
-def payment_gateway_settings():  # noqa: PT004
+def payment_gateway_settings():
     settings.MITOL_PAYMENT_GATEWAY_CYBERSOURCE_SECURITY_KEY = "Test Security Key"
     settings.MITOL_PAYMENT_GATEWAY_CYBERSOURCE_ACCESS_KEY = "Test Access Key"
     settings.MITOL_PAYMENT_GATEWAY_CYBERSOURCE_PROFILE_ID = uuid.uuid4()

fixtures/common.py

@@ -131,13 +131,13 @@ def user_profile_dict():
 
 
 @pytest.fixture
-def nplusone_fail(settings):  # noqa: PT004
+def nplusone_fail(settings):
     """Configures the nplusone app to raise errors"""
     settings.NPLUSONE_RAISE = True
 
 
 @pytest.fixture(autouse=True)
-def webpack_stats(settings):  # noqa: PT004
+def webpack_stats(settings):
     """Mocks out webpack stats"""
 
     directory = "scripts/test/data/webpack-stats/"
@@ -151,7 +151,7 @@ def webpack_stats(settings):  # noqa: PT004
 
 
 @pytest.fixture
-def raise_nplusone(request):  # noqa: PT004
+def raise_nplusone(request):
     if request.node.get_closest_marker("skip_nplusone"):
         yield
     else:

mail/api_test.py

@@ -25,7 +25,7 @@
 
 
 @pytest.fixture
-def email_settings(settings):  # noqa: PT004
+def email_settings(settings):
     """Default settings for email tests"""
     settings.MAILGUN_RECIPIENT_OVERRIDE = None
 

users/serializers_test.py

@@ -29,7 +29,7 @@
 
 
 @pytest.fixture
-def application(settings):  # noqa: PT004
+def application(settings):
     """Test data and settings needed for create_edx_user tests"""
     settings.OPENEDX_API_BASE_URL = "http://example.com"