Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serve course catalog page from Wagtail #157

Closed
gsidebo opened this issue Apr 17, 2019 · 2 comments · Fixed by #411
Closed

Serve course catalog page from Wagtail #157

gsidebo opened this issue Apr 17, 2019 · 2 comments · Fixed by #411
Assignees
@ahmed-arbisoft

Comments

@gsidebo
Copy link
Contributor

gsidebo commented Apr 17, 2019 •
edited
Loading

Depends on #155

The course catalog page was updated in #1 to run a query for Courses and Programs and fetch some related content from their associated Wagtail pages. We've decided not to show programs/courses in the catalog if they don't have a Wagtail page, so it makes more sense to use Wagtail to serve the catalog page(s). One complicating factor: the new design calls for a catalog page that shows programs only, courses only, or both. It's not yet obvious how we're going to use Wagtail the catalog page with both programs and courses.

Rough requirements:

  • Move catalog templates from the courses app to the cms app
  • Set the courses listing page and programs listing page to render the above template
  • Support the combined programs + courses catalog view via Wagtail (research needed)
  • Remove Course/Program properties that pull values from the associated Wagtail page if they're not necessary anymore
@gsidebo gsidebo mentioned this issue Apr 19, 2019
Closed
@pdpinch pdpinch added this to the 05/13/2019 milestone May 3, 2019
This was referenced May 3, 2019
Closed
Merged
@pdpinch pdpinch removed this from the 05/13/2019 milestone May 10, 2019
@pdpinch
Copy link
Member

pdpinch commented May 10, 2019

This is blocked by #214

@pdpinch
Copy link
Member

pdpinch commented May 14, 2019

#214 is merged, so this is no longer blocked.

@pdpinch pdpinch removed the Blocked label May 14, 2019
ahmed-arbisoft pushed a commit that referenced this issue May 30, 2019
#157 Serve Catalog Page from Wagtail
803281c
@ahmed-arbisoft ahmed-arbisoft mentioned this issue May 30, 2019
Merged
4 tasks
ahmed-arbisoft pushed a commit that referenced this issue May 30, 2019
#157 Serve Catalog Page from Wagtail
1d5b7ab
ahmed-arbisoft pushed a commit that referenced this issue Jun 5, 2019
#157 Serve Catalog Page from Wagtail
74ab561 
Missed change
Rebase and Migration Fixes
Feedback
collapsible tags fix
Fix typo and feedback
ahmed-arbisoft added a commit that referenced this issue Jun 5, 2019
@ahmed-arbisoft
Merge pull request #411 from mitodl/ahmedbelal/157-serve-catalog-page…
7eb87d0 
…-wagtail

#157 Serve Catalog Page from Wagtail
@odlbot odlbot mentioned this issue Jun 6, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahmed-arbisoft ahmed-arbisoft

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#157 Serve Catalog Page from Wagtail mitodl/mitxpro
3 participants
@pdpinch @gsidebo @ahmed-arbisoft