Add news and events carousel #2111

HamzaIbnFarooq · 2021-02-04T12:45:24Z

Pre-Flight checklist

Screenshots and design review for any changes that affect layout or styling
- Desktop screenshots
- Mobile width screenshots
Migrations
- Migration is backwards-compatible with current production code
Testing
- Code is tested
- Changes have been manually tested

What are the relevant tickets?

#2108

What's this PR do?

Adds a NEWS/EVENTS section to HomePage.

How should this be manually tested?

Go to cms
Under HomePage create a News and Events Page
Add the required fields and save
A new section should appear below testimonial on your HomePage

Screenshots (if appropriate)

Desktop:

Mobile:

codecov-io · 2021-02-04T13:50:20Z

Codecov Report

Merging #2111 (c87bd72) into master (3b19dc7) will increase coverage by 0.01%.
The diff coverage is 90.24%.

@@            Coverage Diff             @@
##           master    #2111      +/-   ##
==========================================
+ Coverage   87.96%   87.97%   +0.01%     
==========================================
  Files         328      328              
  Lines       14778    14819      +41     
  Branches     1032     1033       +1     
==========================================
+ Hits        12999    13037      +38     
- Misses       1540     1542       +2     
- Partials      239      240       +1

Impacted Files	Coverage Δ
cms/models.py	`90.78% <80.00%> (-0.44%)`	⬇️
cms/blocks.py	`83.67% <100.00%> (+2.72%)`	⬆️
cms/factories.py	`94.47% <100.00%> (+0.38%)`	⬆️
...tic/js/components/forms/BulkEnrollmentForm_test.js	`100.00% <0.00%> (+1.26%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b19dc7...7a233ef. Read the comment docs.

briangrossman · 2021-02-08T17:05:10Z

@HamzaIbnFarooq
Screenshots look good to me (and Abdul).
Nice work!

asadiqbal08

Over all it seems me great beside few suggestions.

asadiqbal08 · 2021-02-09T11:39:41Z

cms/blocks.py

+    Custom block to represent a news or event
+    """
+
+    content_type = blocks.CharBlock(max_length=100, help_text="The type of update.")


suggestion: I would prefer Specify the news/events type here

asadiqbal08 · 2021-02-09T11:39:51Z

cms/blocks.py

+    """
+
+    content_type = blocks.CharBlock(max_length=100, help_text="The type of update.")
+    title = blocks.CharBlock(max_length=255, help_text="The title of update.")


suggestion: I would prefer Specify the news/events title here

asadiqbal08 · 2021-02-09T11:40:27Z

cms/blocks.py

+    content_type = blocks.CharBlock(max_length=100, help_text="The type of update.")
+    title = blocks.CharBlock(max_length=255, help_text="The title of update.")
+    image = ImageChooserBlock(
+        blank=True, null=True, help_text="The image to display on the update."


suggestion: I would prefer Specify the image for news/events section

asadiqbal08 · 2021-02-09T11:41:13Z

cms/blocks.py

+    call_to_action = blocks.CharBlock(
+        max_length=100, help_text="The call to action of update."
+    )
+    action_url = blocks.URLBlock(help_text="The call to action url of update.")


Can we add an example here for the action_url , I mean a bit more specific to new ones.

asadiqbal08 · 2021-02-09T11:41:43Z

cms/blocks.py

+        blank=True, null=True, help_text="The image to display on the update."
+    )
+    content = blocks.TextBlock(help_text="The content that appears on the update card.")
+    call_to_action = blocks.CharBlock(


a bit more explanatory with any possible e.g. value ?

asadiqbal08 · 2021-02-09T11:48:16Z

cms/templates/partials/news-and-events-carousel.html

+            <img src="{% image_version_url card.value.image "fill-330x200" %}" alt="{{ card.value.name }}" width="330" height="200" loading="lazy"/>
+          {% endif %}
+          <div class="card-type">
+            {{ card.value.content_type }}


are we considering to keep these values required in CMS ? I just mean, if no any data then we may have empty HTML tags here.

All fields are mandatory right now, according to the requirements.

asadiqbal08 · 2021-02-09T11:48:40Z

cms/templates/partials/news-and-events-carousel.html

+            {{ card.value.content_type }}
+          </div>
+          <p class="title">{{ card.value.title }}</p>
+          <p class="content">{{ card.value.content|truncatechars:150 }}</p>


Are we considering to keep these values required in CMS ? I just mean, if no any data then we may have empty HTML tags here.

All fields are mandatory right now, according to the requirements.

HamzaIbnFarooq · 2021-02-10T09:06:12Z

@asadiqbal08 I have done a small design change of removing icomoon usage in this PR, kindly have a look again to test the changes.

HamzaIbnFarooq · 2021-02-10T09:07:30Z

@briangrossman can you please re-verify the attached design as I have replaced icomoon icons with material design ones, according to this PR #2093

briangrossman · 2021-02-10T21:42:57Z

@HamzaIbnFarooq Thanks for pointing this out. Those icons look totally fine.

HamzaIbnFarooq added the Work in Progress label Feb 4, 2021

odlbot temporarily deployed to xpro-ci-pr-2111 February 4, 2021 12:46 Inactive

odlbot temporarily deployed to xpro-ci-pr-2111 February 4, 2021 13:50 Inactive

HamzaIbnFarooq force-pushed the hamza/2108-news_and_events_carousel branch from d2a36d4 to 8c48bc9 Compare February 4, 2021 13:52

odlbot temporarily deployed to xpro-ci-pr-2111 February 4, 2021 13:53 Inactive

HamzaIbnFarooq added Needs Review and removed Work in Progress labels Feb 4, 2021

HamzaIbnFarooq requested review from arslanashraf7, mbertrand and briangrossman February 4, 2021 14:11

HamzaIbnFarooq changed the title ~~Hamza/2108 news and events carousel~~ Add news and events carousel Feb 4, 2021

HamzaIbnFarooq force-pushed the hamza/2108-news_and_events_carousel branch from 8c48bc9 to a27a056 Compare February 8, 2021 06:17

odlbot temporarily deployed to xpro-ci-pr-2111 February 8, 2021 06:18 Inactive

HamzaIbnFarooq requested a review from asadiqbal08 February 9, 2021 06:50

HamzaIbnFarooq added Work in Progress and removed Needs Review labels Feb 9, 2021

odlbot temporarily deployed to xpro-ci-pr-2111 February 9, 2021 10:11 Inactive

HamzaIbnFarooq added Needs Review and removed Work in Progress labels Feb 9, 2021

asadiqbal08 self-assigned this Feb 9, 2021

asadiqbal08 suggested changes Feb 9, 2021

View reviewed changes

asadiqbal08 added Waiting on Author and removed Needs Review labels Feb 9, 2021

odlbot temporarily deployed to xpro-ci-pr-2111 February 9, 2021 12:45 Inactive

HamzaIbnFarooq force-pushed the hamza/2108-news_and_events_carousel branch from 8b6795d to cc38d4c Compare February 9, 2021 12:50

odlbot temporarily deployed to xpro-ci-pr-2111 February 9, 2021 12:50 Inactive

HamzaIbnFarooq force-pushed the hamza/2108-news_and_events_carousel branch from cc38d4c to c87bd72 Compare February 9, 2021 12:52

odlbot temporarily deployed to xpro-ci-pr-2111 February 9, 2021 12:52 Inactive

HamzaIbnFarooq added Needs Review and removed Waiting on Author labels Feb 9, 2021

HamzaIbnFarooq requested a review from asadiqbal08 February 9, 2021 12:53

asadiqbal08 approved these changes Feb 9, 2021

View reviewed changes

HamzaIbnFarooq force-pushed the hamza/2108-news_and_events_carousel branch from c87bd72 to 7a233ef Compare February 9, 2021 13:56

odlbot temporarily deployed to xpro-ci-pr-2111 February 9, 2021 13:56 Inactive

HamzaIbnFarooq added 2 commits February 10, 2021 13:08

add news and events section to HomePage

685523c

removing icomoons

1c69169

HamzaIbnFarooq force-pushed the hamza/2108-news_and_events_carousel branch from 7a233ef to 1c69169 Compare February 10, 2021 08:26

odlbot deployed to xpro-ci-pr-2111 February 10, 2021 08:26 View deployment

HamzaIbnFarooq requested a review from asadiqbal08 February 10, 2021 09:04

asadiqbal08 approved these changes Feb 10, 2021

View reviewed changes

HamzaIbnFarooq assigned briangrossman and unassigned asadiqbal08 Feb 10, 2021

HamzaIbnFarooq removed the Needs Review label Feb 11, 2021

HamzaIbnFarooq assigned HamzaIbnFarooq and unassigned briangrossman Feb 11, 2021

HamzaIbnFarooq merged commit 8ae2481 into master Feb 11, 2021

HamzaIbnFarooq deleted the hamza/2108-news_and_events_carousel branch February 11, 2021 03:57

odlbot mentioned this pull request Feb 11, 2021

Release 0.76.2 #2123

Merged

7 tasks

HamzaIbnFarooq mentioned this pull request Feb 18, 2021

News and Events carousel on home page #2108

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add news and events carousel #2111

Add news and events carousel #2111

HamzaIbnFarooq commented Feb 4, 2021 •

edited

Loading

codecov-io commented Feb 4, 2021 •

edited

Loading

briangrossman commented Feb 8, 2021

asadiqbal08 left a comment

asadiqbal08 Feb 9, 2021

HamzaIbnFarooq Feb 9, 2021

asadiqbal08 Feb 9, 2021

HamzaIbnFarooq Feb 9, 2021

asadiqbal08 Feb 9, 2021

HamzaIbnFarooq Feb 9, 2021

asadiqbal08 Feb 9, 2021

HamzaIbnFarooq Feb 9, 2021

asadiqbal08 Feb 9, 2021

HamzaIbnFarooq Feb 9, 2021

asadiqbal08 Feb 9, 2021

HamzaIbnFarooq Feb 9, 2021

asadiqbal08 Feb 9, 2021

HamzaIbnFarooq Feb 9, 2021

HamzaIbnFarooq commented Feb 10, 2021

HamzaIbnFarooq commented Feb 10, 2021 •

edited

Loading

briangrossman commented Feb 10, 2021

Add news and events carousel #2111

Add news and events carousel #2111

Conversation

HamzaIbnFarooq commented Feb 4, 2021 • edited Loading

Pre-Flight checklist

What are the relevant tickets?

What's this PR do?

How should this be manually tested?

Screenshots (if appropriate)

codecov-io commented Feb 4, 2021 • edited Loading

Codecov Report

briangrossman commented Feb 8, 2021

asadiqbal08 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HamzaIbnFarooq commented Feb 10, 2021

HamzaIbnFarooq commented Feb 10, 2021 • edited Loading

briangrossman commented Feb 10, 2021

HamzaIbnFarooq commented Feb 4, 2021 •

edited

Loading

codecov-io commented Feb 4, 2021 •

edited

Loading

HamzaIbnFarooq commented Feb 10, 2021 •

edited

Loading