Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused JS dependency (validator) #2357

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

arslanashraf7
Copy link
Contributor

@arslanashraf7 arslanashraf7 commented Feb 23, 2022

Pre-Flight checklist

What are the relevant tickets?

What's this PR do?

Removed an unused package validator.
While looking at the dependabot PR(#2320), I noticed that the package is not used anywhere. So, instead of the bump, I've created this PR to remove this unused package.

How should this be manually tested?

  • tests passing
  • Reconfirming that we aren't using it anywhere, not even dynamically.

Reviewer Note:

Upon merging this PR i'll be closing #2320, since it won't be needed anymore.

@codecov-commenter
Copy link

Codecov Report

Merging #2357 (7636e37) into master (19031f3) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2357   +/-   ##
=======================================
  Coverage   88.21%   88.21%           
=======================================
  Files         330      330           
  Lines       15098    15098           
  Branches     1702     1702           
=======================================
+ Hits        13318    13319    +1     
+ Misses       1532     1531    -1     
  Partials      248      248           
Impacted Files Coverage Δ
static/js/components/forms/BulkEnrollmentForm.js 92.18% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19031f3...7636e37. Read the comment docs.

Copy link
Contributor

@asadiqbal08 asadiqbal08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@arslanashraf7 arslanashraf7 force-pushed the arslan/remove-validator branch from 7636e37 to 35176cb Compare March 1, 2022 13:23
@arslanashraf7 arslanashraf7 merged commit 7758574 into master Mar 1, 2022
@arslanashraf7 arslanashraf7 deleted the arslan/remove-validator branch March 1, 2022 13:39
This was referenced Mar 7, 2022
@odlbot odlbot mentioned this pull request Mar 16, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants