#145 Product Page: Learners Carousel #237

ahmed-arbisoft · 2019-05-08T20:30:11Z

Pre-Flight checklist

Screenshots and design review for any changes that affect layout or styling
- Desktop screenshots
- Mobile width screenshots
- Tag @Ferdi or @pdpinch for review
Migrations
- Migration is backwards-compatible with current production code
Testing
- Code is tested
- Changes have been manually tested

What are the relevant tickets?

Closes #145

What's this PR do?

Adds a UserTestimonialsPage type subpage as candidate child to a product page.

How should this be manually tested?

Add the respective subpage to a product page, the carousel should appear as per specs, showing testimonials added via the wagtail admin.

Screenshots (if appropriate)

codecov-io · 2019-05-08T20:38:54Z

Codecov Report

Merging #237 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #237      +/-   ##
=========================================
+ Coverage   94.27%   94.3%   +0.02%     
=========================================
  Files         157     157              
  Lines        5133    5160      +27     
  Branches      309     309              
=========================================
+ Hits         4839    4866      +27     
  Misses        238     238              
  Partials       56      56

Impacted Files	Coverage Δ
courses/models.py	`95.88% <100%> (+0.04%)`	⬆️
cms/blocks.py	`100% <100%> (ø)`	⬆️
cms/models.py	`93.75% <100%> (+0.41%)`	⬆️
cms/factories.py	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4936cef...57a70fe. Read the comment docs.

pdpinch · 2019-05-08T20:40:59Z

sorry for the delay @asadiqbal08. Here's the design: https://invis.io/EFRWZWL4TZ5#/362236630_MITxPro_ReadMore_Modal

asadiqbal08 · 2019-05-09T12:01:32Z

cms/models.py

@@ -267,6 +294,7 @@ class Meta:
        "ForTeamsPage",
        "WhoShouldEnrollPage",
        "CoursesInProgramPage",
+        "UserTestimonialsPage",


may be in next upcoming PR , re order the list according to .psd sections.

asadiqbal08 · 2019-05-09T12:02:15Z

courses/templates/partials/metadata-tiles.html

@@ -27,7 +27,7 @@
      {% if course.current_price %}
        <li>
          <span class="title">PRICE</span>
-          <span class="text">${{ course.current_price }}</span>
+          <span class="text">${{ course.current_price|floatformat:"0" }}</span>


asadiqbal08 · 2019-05-09T12:03:54Z

courses/templates/partials/testimonial-carousel.html

+      </div>
+    </div>
+  {% endfor %}
+</div>


asadiqbal08 · 2019-05-09T12:04:10Z

static/fonts/icomoon.svg

@@ -13,4 +13,5 @@
 <glyph unicode="&#xe903;" glyph-name="arrow-circle-left" horiz-adv-x="878" d="M731.429 402.286v73.143c0 20-16.571 36.571-36.571 36.571h-286.857l108 108c6.857 6.857 10.857 16 10.857 25.714s-4 18.857-10.857 25.714l-52 52c-6.857 6.857-16 10.286-25.714 10.286s-18.857-3.429-25.714-10.286l-258.857-258.857c-6.857-6.857-10.286-16-10.286-25.714s3.429-18.857 10.286-25.714l258.857-258.857c6.857-6.857 16-10.286 25.714-10.286s18.857 3.429 25.714 10.286l52 52c6.857 6.857 10.286 16 10.286 25.714s-3.429 18.857-10.286 25.714l-108 108h286.857c20 0 36.571 16.571 36.571 36.571zM877.714 438.857c0-242.286-196.571-438.857-438.857-438.857s-438.857 196.571-438.857 438.857 196.571 438.857 438.857 438.857 438.857-196.571 438.857-438.857z" />
 <glyph unicode="&#xe904;" glyph-name="arrow-circle-down" horiz-adv-x="878" d="M733.714 438.286c0 9.714-3.429 18.857-10.286 25.714l-52 52c-6.857 6.857-16 10.286-25.714 10.286s-18.857-3.429-25.714-10.286l-108-108v286.857c0 20-16.571 36.571-36.571 36.571h-73.143c-20 0-36.571-16.571-36.571-36.571v-286.857l-108 108c-6.857 6.857-16 10.857-25.714 10.857s-18.857-4-25.714-10.857l-52-52c-6.857-6.857-10.286-16-10.286-25.714s3.429-18.857 10.286-25.714l258.857-258.857c6.857-6.857 16-10.286 25.714-10.286s18.857 3.429 25.714 10.286l258.857 258.857c6.857 6.857 10.286 16 10.286 25.714zM877.714 438.857c0-242.286-196.571-438.857-438.857-438.857s-438.857 196.571-438.857 438.857 196.571 438.857 438.857 438.857 438.857-196.571 438.857-438.857z" />
 <glyph unicode="&#xe905;" glyph-name="arrow-circle-up" horiz-adv-x="878" d="M733.714 439.428c0 9.714-3.429 18.857-10.286 25.714l-258.857 258.857c-6.857 6.857-16 10.286-25.714 10.286s-18.857-3.429-25.714-10.286l-258.857-258.857c-6.857-6.857-10.286-16-10.286-25.714s3.429-18.857 10.286-25.714l52-52c6.857-6.857 16-10.286 25.714-10.286s18.857 3.429 25.714 10.286l108 108v-286.857c0-20 16.571-36.571 36.571-36.571h73.143c20 0 36.571 16.571 36.571 36.571v286.857l108-108c6.857-6.857 16-10.857 25.714-10.857s18.857 4 25.714 10.857l52 52c6.857 6.857 10.286 16 10.286 25.714zM877.714 438.857c0-242.286-196.571-438.857-438.857-438.857s-438.857 196.571-438.857 438.857 196.571 438.857 438.857 438.857 438.857-196.571 438.857-438.857z" />
-</font></defs></svg>
+<glyph unicode="&#xe906;" glyph-name="close-outline" d="M150.016 98.816c-96.436 93.233-156.308 223.762-156.308 368.276 0 282.77 229.23 512 512 512 144.514 0 275.043-59.872 368.137-156.164l0.138-0.144c88.925-91.979 143.724-217.436 143.724-355.692 0-282.77-229.23-512-512-512-138.256 0-263.713 54.799-355.836 143.863l0.144-0.138zM222.208 171.008c74.164-74.164 176.621-120.036 289.792-120.036 226.342 0 409.828 183.486 409.828 409.828 0 113.171-45.872 215.628-120.036 289.792v0c-74.164 74.164-176.621 120.036-289.792 120.036-226.342 0-409.828-183.486-409.828-409.828 0-113.171 45.872-215.628 120.036-289.792v0zM729.088 605.696l-144.896-144.896 144.896-144.896-72.192-72.192-144.896 144.896-144.896-144.896-72.192 72.192 144.896 144.896-144.896 144.896 72.192 72.192 144.896-144.896 144.896 144.896 72.192-72.192z" />
+</font></defs></svg>


nit: newline

asadiqbal08 · 2019-05-09T12:05:20Z

static/scss/detail/testimonial-carousel.scss

+.quote-container {
+  max-height: 50vh;
+  overflow: auto;
+}


nit: Newline

asadiqbal08 · 2019-05-09T12:05:44Z

static/scss/detail/testimonial-carousel.scss

+
+.headshot-image {
+  box-shadow: 0em 0.05em 0.5em rgba(0, 0, 0, 0.35);
+  border-width: 3px !important;


why !important here ?

The bootstrap border class used in conjunction with this already defines the border-width with !important so I need this to override it.

asadiqbal08 · 2019-05-09T12:05:57Z

static/scss/slick.scss

@@ -215,4 +215,4 @@
      }
    }
  }
-}
+}


asadiqbal08 · 2019-05-09T12:19:34Z

@ahmed-arbisoft overall it LGTM 👍 few nits only.

pdpinch · 2019-05-13T14:02:19Z

Hopefully we will get this Travis issue fixed by the time you get in tomorrow

odlbot temporarily deployed to xpro-ci-pr-237 May 8, 2019 20:30 Inactive

ahmed-arbisoft requested review from tasawernawaz and asadiqbal08 May 8, 2019 20:30

odlbot deployed to xpro-ci-pr-237 May 9, 2019 11:29 View deployment

ahmed-arbisoft added the Needs Review label May 9, 2019

ahmed-arbisoft assigned asadiqbal08 May 9, 2019

asadiqbal08 reviewed May 9, 2019

View reviewed changes

courses/templates/partials/testimonial-carousel.html

</div>

</div>

{% endfor %}

</div>

Copy link

Contributor

asadiqbal08 May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: here.

asadiqbal08 reviewed May 9, 2019

View reviewed changes

static/scss/detail/testimonial-carousel.scss

.quote-container {

max-height: 50vh;

overflow: auto;

}

Copy link

Contributor

asadiqbal08 May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Newline

asadiqbal08 reviewed May 9, 2019

View reviewed changes

static/scss/slick.scss

@@ -215,4 +215,4 @@

}

}

}

}

}

Copy link

Contributor

asadiqbal08 May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

asadiqbal08 approved these changes May 9, 2019

View reviewed changes

ahmed-arbisoft requested a review from pdpinch May 9, 2019 13:14

ahmed-arbisoft assigned pdpinch and unassigned asadiqbal08 May 9, 2019

ahmed-arbisoft force-pushed the ahmedbelal/145-product-page-learners-carousel branch from 8a5792d to b3e8870 Compare May 10, 2019 08:49

odlbot had a problem deploying to xpro-ci-pr-237 May 10, 2019 08:50 Failure

ahmed-arbisoft force-pushed the ahmedbelal/145-product-page-learners-carousel branch from b3e8870 to e7981aa Compare May 11, 2019 16:16

odlbot had a problem deploying to xpro-ci-pr-237 May 11, 2019 16:17 Failure

pdpinch removed their assignment May 13, 2019

pdpinch assigned ahmed-arbisoft May 13, 2019

gsidebo mentioned this pull request May 13, 2019

Integrated Wagtail to support course/program detail pages #264

Closed

7 tasks

#145 Product Page: Learners Carousel

57a70fe

ahmed-arbisoft force-pushed the ahmedbelal/145-product-page-learners-carousel branch from e7981aa to 57a70fe Compare May 14, 2019 07:36

odlbot had a problem deploying to xpro-ci-pr-237 May 14, 2019 07:37 Failure

ahmed-arbisoft merged commit ff614d9 into master May 14, 2019

ahmed-arbisoft deleted the ahmedbelal/145-product-page-learners-carousel branch July 10, 2019 12:34

briangrossman mentioned this pull request Feb 2, 2021

News and Events carousel on home page #2108

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#145 Product Page: Learners Carousel #237

#145 Product Page: Learners Carousel #237

ahmed-arbisoft commented May 8, 2019 •

edited

Loading

codecov-io commented May 8, 2019 •

edited

Loading

pdpinch commented May 8, 2019

asadiqbal08 May 9, 2019

asadiqbal08 May 9, 2019

asadiqbal08 May 9, 2019

asadiqbal08 May 9, 2019

asadiqbal08 May 9, 2019

asadiqbal08 May 9, 2019

ahmed-arbisoft May 9, 2019

asadiqbal08 May 9, 2019

asadiqbal08 commented May 9, 2019

pdpinch commented May 13, 2019

@@ @@ -215,4 +215,4 @@ @@
                     }
                   }
                 }
-              }
+              }

#145 Product Page: Learners Carousel #237

#145 Product Page: Learners Carousel #237

Conversation

ahmed-arbisoft commented May 8, 2019 • edited Loading

Pre-Flight checklist

What are the relevant tickets?

What's this PR do?

How should this be manually tested?

Screenshots (if appropriate)

codecov-io commented May 8, 2019 • edited Loading

Codecov Report

pdpinch commented May 8, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asadiqbal08 commented May 9, 2019

pdpinch commented May 13, 2019

ahmed-arbisoft commented May 8, 2019 •

edited

Loading

codecov-io commented May 8, 2019 •

edited

Loading