505 merging of multiple bundles into a single matrix #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemiller
reviewed
Feb 21, 2024
Comment on lines
36
to
38
| public get_technique_domain(stixSDO: any): string { | ||
| return stixSDO.x_mitre_domains[0]; | ||
| } |
There was a problem hiding this comment.
- For techniques in multiple domains, this function would only check the first listed domain and disregard all other domains. While ATT&CK doesn't currently have cross-domain techniques, this should support custom datasets that do.
- I suggest removing the
stixSDOparameter from this function, and instead update the Technique constructor (which already has access to thestixSDO) to store thex_mitre_domainfield as a class property. This would enhance the accessibility of the data within the class.
clemiller
reviewed
Feb 21, 2024
Comment on lines
239
to
241
| if(domain.techniques[j].get_technique_domain(techniqueSDOslist[j]) == matricesList[i].external_references[0].external_id) { | ||
| techniquesList.push(domain.techniques[j]); | ||
| } |
There was a problem hiding this comment.
This logic should be updated to check if the matrix ID matches any of the domains listed in the technique's x_mitre_domains field. See other comment for more details.
matricesList[i].external_references[0].external_id == domain[techniques[j].x_mitre_domains
clemiller
requested changes
Feb 21, 2024
clemiller
reviewed
Feb 22, 2024
|
clemiller
deleted the
505-merging-of-multiple-bundles-into-a-single-matrix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #505.