Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VIRTS-2743] Abilities v2 API tests #2228

Merged
merged 14 commits into from
Sep 2, 2021

Conversation

bleepbop
Copy link
Contributor

Description

Unit Tests for Abilities V2 API. DELETE endpoint is currently untested, due to underlying aiohttp issue.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Verified that tests work for various python versions using tox.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #2228 (8f75bd7) into master (33d9085) will increase coverage by 1.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2228      +/-   ##
==========================================
+ Coverage   67.04%   68.67%   +1.62%     
==========================================
  Files          92       94       +2     
  Lines        7286     7409     +123     
==========================================
+ Hits         4885     5088     +203     
+ Misses       2401     2321      -80     
Impacted Files Coverage Δ
app/service/rest_svc.py 45.81% <0.00%> (-0.24%) ⬇️
app/api/v2/handlers/ability_api.py 96.22% <0.00%> (ø)
app/api/v2/managers/ability_api_manager.py 90.00% <0.00%> (ø)
app/objects/c_ability.py 94.26% <0.00%> (+0.81%) ⬆️
app/service/file_svc.py 63.84% <0.00%> (+1.87%) ⬆️
app/api/v2/managers/base_api_manager.py 78.94% <0.00%> (+9.64%) ⬆️
app/service/data_svc.py 41.47% <0.00%> (+9.69%) ⬆️
app/api/v2/handlers/base_object_api.py 73.00% <0.00%> (+45.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d9085...8f75bd7. Read the comment docs.

@bleepbop bleepbop requested review from uruwhy and clenk August 17, 2021 20:45
Copy link
Contributor

@uruwhy uruwhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple tweaks and changes - great first pass!

@bleepbop bleepbop requested a review from uruwhy August 20, 2021 13:51
uruwhy
uruwhy previously approved these changes Aug 20, 2021
Copy link
Contributor

@uruwhy uruwhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bleepbop bleepbop requested review from mchan143 and removed request for clenk August 26, 2021 15:35
@bleepbop bleepbop requested a review from uruwhy August 27, 2021 17:29
Copy link
Contributor

@mchan143 mchan143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bleepbop bleepbop merged commit ac00da6 into master Sep 2, 2021
@bleepbop bleepbop deleted the bleepbop/VIRTS-2743/abilities-api-tests branch September 2, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants