Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tox.ini issues and flake8 link #35

Merged
merged 6 commits into from
Jun 1, 2023
Merged

fix tox.ini issues and flake8 link #35

merged 6 commits into from
Jun 1, 2023

Conversation

uruwhy
Copy link
Contributor

@uruwhy uruwhy commented May 5, 2023 •
edited
Loading

Description

  • Apparently tox was updated so that you can no longer have spaces in passenv, as some users have noted. One workaround is to use commas instead.
  • Flake8 link was switched from gitlab to github.
  • Fixing allowlist_externals in tox.ini to allow tests to run
  • Fixing directories for test commands

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@uruwhy uruwhy changed the title replace whitespaces with commas in tox.ini passenv, and fix flake8 link fix tox.ini issues and flake8 link May 5, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@uruwhy uruwhy marked this pull request as ready for review May 5, 2023 19:16
@uruwhy
update tox.ini
90be96f 
remove sudo from externals
clenk
clenk approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@clenk clenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@clenk clenk merged commit 406a2c7 into master Jun 1, 2023
@clenk clenk deleted the tox-update-passenv branch June 1, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clenk clenk clenk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uruwhy @clenk