Undefined Evaluation Bug Fix #5234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ChrisHinchey
commented
Nov 11, 2023
•
ChrisHinchey
commented
- Fixes [BUG] spitting warnings about an undefined variable when saving to the db #5227
Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org>
Amndeep7
approved these changes
Nov 14, 2023
|
@ChrisHinchey before we merge, can you spin up a heroku deployment so we can test saving it to the db? if that succeeds with no errors then we can merge (i've already approved it, so just apply the ready to merge label) |
ChrisHinchey
temporarily deployed
to
heimdall2-fix-5227-wg6gyiunfce
|
@Amndeep7 After spinning up the review app, loading a sample, and saving it to the database I don't get any console errors for the undefined variable. I'll apply the ready to merge label as previously stated |
ChrisHinchey
added
the
ready-to-merge
|
Kudos, SonarCloud Quality Gate passed!
|
Amndeep7
pushed a commit
that referenced
this pull request
Dec 29, 2023
Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.