Quick Fixes For Heimdall Issues #5237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org>
Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org>
Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org>
Amndeep7
requested changes
Nov 14, 2023
Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org>
Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org>
Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org>
Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org>
Amndeep7
requested changes
Nov 14, 2023
apps/frontend/src/components/cards/controltable/ControlTable.vue
Outdated
Show resolved
Hide resolved
|
@ChrisHinchey can you ask @ejaronne about the private groups issue? I've tested the functionality and it seems like it works, but now there's no way for an admin to know that a private group is attached to a given file. We should probably add a new tab in the admin panel to manage files. This should be spun off as a new task and shoved underneath the groups epic imo. |
Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org>
Co-authored-by: Amndeep Singh Mann <amann@mitre.org>
Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org>
Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org>
|
@ChrisHinchey please see new comments |
Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org>
Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org>
Amndeep7
approved these changes
Dec 5, 2023
Amndeep7
added
the
ready-to-merge
|
Kudos, SonarCloud Quality Gate passed!
|
Amndeep7
added a commit
that referenced
this pull request
Dec 29, 2023
* Local login show password Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org> * Fix viewed number when filtering Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org> * Fix private groups being shown Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org> * Proper formatting Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org> * Use id instead of email Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org> * Compose depends on condition and remove version Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org> * Went back to array instead of set Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org> * Removed array spread Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org> * Update apps/frontend/src/components/global/login/LocalLogin.vue Co-authored-by: Amndeep Singh Mann <amann@mitre.org> * Changed to use myGroup from store Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org> * Add database health check Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org> * Ran lint Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org> * Fix intersection of group arrays Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org> * Fixed healthcheck Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org> --------- Signed-off-by: Christopher Andrew Hinchey <chinchey@mitre.org> Co-authored-by: Amndeep Singh Mann <amann@mitre.org> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkmark = @Amndeep7's signoff approval on functionality (there might still be comments on improving the code)