Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build rpm packages #2620

Merged
merged 15 commits into from
Jun 19, 2024
Merged

Build rpm packages #2620

merged 15 commits into from
Jun 19, 2024

Conversation

Amndeep7
Copy link
Contributor

@Amndeep7 Amndeep7 commented Jun 4, 2024

No description provided.

@Amndeep7 Amndeep7 requested a review from wdower June 15, 2024 09:53
@Amndeep7 Amndeep7 marked this pull request as ready for review June 15, 2024 09:53
aaronlippold
aaronlippold previously requested changes Jun 15, 2024
View reviewed changes
saf.spec Outdated Show resolved Hide resolved
saf.spec Outdated Show resolved Hide resolved
Amndeep7 added 13 commits June 17, 2024 17:42
@Amndeep7 @wdower
wip spec file
1759403 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7 @wdower
don't need a service file when we're only providing a cli utility
98c11ca 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7 @wdower
removing speculate as a dependency
22762a7 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7 @wdower
removing test output file
215c8dc 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7 @wdower
several rewrites to remove what speculate was doing and eventually fi…
bb7634b 
…gure out what I actually needed to do to write a proper spec file

Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7 @wdower
stub out workflow
08e675d 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7 @wdower
moved spec file to root of dir and also hard code the defines for the…
b195358 
… name (saf) and release number (1 since we would push out a new version entirely on any update)

Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7 @wdower
gitignore more vim temp files
93d1f4f 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7 @wdower
first attempt at rpm workflow
420cf15 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7 @wdower
Forgot to update the workflow name to be about rpms
34f5d5f 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7 @wdower
add shasum dependency
5f22030 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7 @wdower
make the container run as root
4075496 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7 @wdower
make rpmbuild use a filename that matches same format as all the othe…
6ace070 
…r release artifacts

Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
wdower
wdower approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@wdower wdower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled the action artifact and installed it on a test VM successfully. LGTM.

.github/workflows/build-rpm.yml Show resolved Hide resolved
saf.spec Show resolved Hide resolved
@Amndeep7
Didn't realize that the requires line could include version restrictions
1efb3a3 
Signed-off-by: Amndeep Singh Mann <amann@mitre.org>
@Amndeep7 Amndeep7 added the ready-to-merge Used by mergify to identify if a PR is ready to merge into main. label Jun 19, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mergify mergify bot merged commit 1192741 into main Jun 19, 2024
15 checks passed
@mergify mergify bot deleted the rpm branch June 19, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wdower wdower wdower approved these changes

@aaronlippold aaronlippold aaronlippold left review comments

Assignees
No one assigned
Labels
ready-to-merge Used by mergify to identify if a PR is ready to merge into main.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Amndeep7 @aaronlippold @wdower