Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated tests to oclif v4 baseline #3065

Merged
merged 8 commits into from
Nov 20, 2024
Merged

Updated tests to oclif v4 baseline #3065

merged 8 commits into from
Nov 20, 2024

Conversation

georgedias
Copy link
Contributor

@georgedias georgedias commented Nov 19, 2024 •
edited
Loading

@georgedias
Updated tests to oclif v4 baseline - added tests from PR 2221
e86e3ae 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias georgedias self-assigned this Nov 19, 2024
@georgedias georgedias requested a review from DMedina6 November 19, 2024 22:17
@georgedias
Updated Deepsource findings and changed convertFullPathToFilename fun…
3fcc9a7 
…ction to work with multiple platforms

Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias
Removed unused import
eed804c 
Signed-off-by: George M Dias <GDIAS@MITRE.ORG>
@georgedias georgedias mentioned this pull request Nov 20, 2024
Closed
8 tasks
georgedias and others added 5 commits November 19, 2024 20:50
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
23.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@georgedias georgedias added documentation Improvements or additions to documentation enhancement New feature or request ready-to-merge Used by mergify to identify if a PR is ready to merge into main. labels Nov 20, 2024
DMedina6
DMedina6 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@DMedina6 DMedina6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Tests all pass on my end.

@DMedina6 DMedina6 merged commit 1e9af75 into main Nov 20, 2024
18 of 19 checks passed
@mergify mergify bot deleted the convert_tests_to_oclif_v4 branch November 20, 2024 20:03
@georgedias georgedias linked an issue Nov 21, 2024 that may be closed by this pull request
Add unit tests to saf view heimdall #2207
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMedina6 DMedina6 DMedina6 approved these changes

Assignees

@georgedias georgedias

Labels
documentation Improvements or additions to documentation enhancement New feature or request ready-to-merge Used by mergify to identify if a PR is ready to merge into main.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit tests to saf view heimdall
2 participants
@georgedias @DMedina6