Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linux and CentOS compilation #38

Closed

Conversation

amyspark
Copy link
Contributor

@amyspark amyspark commented Oct 10, 2017

 - Map between Qt package names and pkg-config names; fixes mitsuba-renderer#32
 - thread.cpp: pthreads needed an additional parameter, my bad
@amyspark amyspark force-pushed the hacktoberfest-linux-again branch from e944156 to 4c72da2 Compare October 10, 2017 15:30
@amyspark amyspark changed the title Fix Linux compilation Fix Linux and CentOS compilation Oct 11, 2017
@wjakob
Copy link
Member

wjakob commented Oct 11, 2017

I think the current code is correct for OSX and incorrect for Linux. They have different function signatures, which is a bit confusing.

@amyspark
Copy link
Contributor Author

I've got it working on both MacOS and Linux Mint/Ubuntu (see https://github.com/amyspark/mitsuba/commits/add-license-and-readme). @chaosink, what errors did you get?

@chaosink
Copy link
Contributor

chaosink commented Oct 21, 2017

Why not add , '-std=c++11', '-fPIC' to CXXFLAGS also in config-linux-gcc.py. 😄 Seems only the debug version is tested (I saw it on Travis CI), which is so slow.

Yes. This works on Linux Mint 18.2 for the debug version. For the release version, the two flags need to be added in config-linux-gcc.py.

Thanks for @amyspark .

@chaosink
Copy link
Contributor

chaosink commented Oct 21, 2017

Maybe all the binaries can be put together, just like cmake did in 0.5.0 version.

@amyspark
Copy link
Contributor Author

amyspark commented Oct 21, 2017

@chaosink 🤦‍♀️, I forgot to do it in #36... fix incoming.
As soon as this is merged, I'll add the release version configs to Appveyor and Travis too.

@diiigle
Copy link
Contributor

diiigle commented Nov 23, 2017

confirmed: fixes compilation on Ubuntu (WSL).

@OstZ
Copy link

OstZ commented Mar 21, 2019

why not merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CentOS 7: pthread_setname_np issue failed to build due qt5
5 participants