-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Linux and CentOS compilation #38
Fix Linux and CentOS compilation #38
Conversation
amyspark
commented
Oct 10, 2017
•
edited
Loading
edited
- Map between Qt package names and pkg-config names; fixes failed to build due qt5 #32
- thread.cpp: pthreads needed an additional parameter, my bad; fixes CentOS 7: pthread_setname_np issue #39
- Map between Qt package names and pkg-config names; fixes mitsuba-renderer#32 - thread.cpp: pthreads needed an additional parameter, my bad
e944156
to
4c72da2
Compare
I think the current code is correct for OSX and incorrect for Linux. They have different function signatures, which is a bit confusing. |
I've got it working on both MacOS and Linux Mint/Ubuntu (see https://github.com/amyspark/mitsuba/commits/add-license-and-readme). @chaosink, what errors did you get? |
Why not add Yes. This works on Linux Mint 18.2 for the debug version. For the release version, the two flags need to be added in Thanks for @amyspark . |
Maybe all the binaries can be put together, just like cmake did in 0.5.0 version. |
confirmed: fixes compilation on Ubuntu (WSL). |
why not merge? |