Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New integration test approach #537

Merged
merged 20 commits into from
Aug 2, 2024
Merged
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
{
"editor.formatOnSave": true,
"rust-analyzer.checkOnSave.allFeatures": true,
"rust-analyzer.cargo.allFeatures": true,
"files.trimTrailingWhitespace": true,
"files.insertFinalNewline": true,
"rust-analyzer.checkOnSave.command": "clippy",
"editor.formatOnSave": true,
"rust-analyzer.checkOnSave.allFeatures": true,
"rust-analyzer.cargo.allFeatures": true,
// We have some snapshots that have trailing whitespace. `rustfmt` does this
// for rust files. (We could add something to pre-commit for other files if we
// wanted...)
"files.trimTrailingWhitespace": false,
"files.insertFinalNewline": true,
"rust-analyzer.checkOnSave.command": "clippy"
}
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ All notable changes to insta and cargo-insta are documented here.

## 1.40.0

- Inline snapshots now use with the required number of `#` to escape the
max-sixty marked this conversation as resolved.
Show resolved Hide resolved
snapshot value, rather than always using `###`. If there are no existing `#`
characters in the snapshot value, this will only be a single `#`. This allows
snapshotting values which themselves contain `###`.

- No longer suggest running `cargo insta` message when running `cargo insta test --check`. #515

- Print a clearer error message when accepting a snapshot that was removed. #516
Expand Down
5 changes: 1 addition & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,7 @@ cargotest:
@cargo test -p insta --all-features
@cargo test -p insta --no-default-features
@cargo test -p insta --features redactions -- --test-threads 1
@echo "CARGO-INSTA TESTS"
# Turn off CI flag so that cargo insta test behaves as we expect
# under normal operation
@CI=0 cargo test -p cargo-insta
@cargo test -p cargo-insta

check-minver:
@echo "MINVER CHECK"
Expand Down
1 change: 1 addition & 0 deletions cargo-insta/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,4 @@ tempfile = "3.5.0"

[dev-dependencies]
walkdir = "2.3.1"
similar= "2.2.1"
Loading
Loading