Skip to content

Commit

Permalink
fix(volume provisioning): fix CStor volume creation without PVC
Browse files Browse the repository at this point in the history
This PR fixes CStor volume provisioning issue. Currently
REST request to create CStor volume will fail if request
is made without creating PVC because of following bug:
- When the REST API is called to create volume it will
  verify whether request payload has PVC name. If PVC
  name doesn't exist then it will skip execution of
  `cstor-volume-create-puttargetservice-default` runtask
  but with latest changes of PR [1735](openebs-archive#1735)
   above runtask is not skiped and leads to failure in creation
  of CStor volume.

Signed-off-by: mittachaitu <sai.chaithanya@mayadata.io>
  • Loading branch information
mittachaitu committed Aug 11, 2020
1 parent 230d7bf commit e452a0b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/volume/volume.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ func (v *Operation) Create() (*v1alpha1.CASVolume, error) {
if len(pvcName) == 0 {
cast.Spec.RunTasks.Tasks = util.RemoveItemFromSlice(
cast.Spec.RunTasks.Tasks,
version.WithSuffix("cstor-volume-create-getpvc-default"),
version.WithSuffixLower("cstor-volume-create-getpvc-default"),
)
}

Expand Down

0 comments on commit e452a0b

Please sign in to comment.