Skip to content

Commit

Permalink
Load new CA Certificate from file on certificate error
Browse files Browse the repository at this point in the history
  • Loading branch information
Lucaber committed Apr 29, 2022
1 parent b0cf5eb commit 6a0cad5
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 9 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ const client = new Vault({
### Kubernetes In-Cluster Example

```js
const cert = await fs.readFile("../vault-cacert", "utf8");
const client = new Vault({
vaultAddress: "https://vault:8200",
vaultCaCertificate: cert,
vaultCaCertificatePath: "../vault-cacert",
});

const k8sauth = client.KubernetesAuth({
Expand Down
43 changes: 35 additions & 8 deletions src/Vault.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { resolveURL } from "./util";
import { TotpVaultClient } from "./engines/totp";
import { KVVaultClient } from "./engines/kv";
import { KV2VaultClient } from "./engines";
import { promises as fs } from "fs";

export type VaultHTTPMethods = "GET" | "POST" | "DELETE" | "LIST";
export interface HTTPGETParameters {
Expand All @@ -18,6 +19,7 @@ export interface IVaultConfig {
vaultAddress?: string;
vaultToken?: string;
vaultCaCertificate?: string;
vaultCaCertificatePath?: string;
vaultNamespace?: string;
apiVersion?: string;
}
Expand Down Expand Up @@ -133,6 +135,10 @@ export class Vault {
}
const uri = resolveURL(this.config.vaultAddress!, this.config.apiVersion!, ...path);

if (this.config.vaultCaCertificatePath && !this.config.vaultCaCertificate) {
await this.loadCACert();
}

const requestOptions: request.Options = {
method,
uri: uri.toString(),
Expand All @@ -149,18 +155,32 @@ export class Vault {
qs: parameters,
};

let res = await request(requestOptions);
let res;
let retry = false;
try {
res = await request(requestOptions);
} catch (e) {
if (e.error && e.error.code === "CERT_SIGNATURE_FAILURE" && this.config.vaultCaCertificatePath) {
await this.loadCACert();
requestOptions.ca = this.config.vaultCaCertificate;
retry = true;
} else {
throw e;
}
}

if (this.tokenClient && options.retryWithTokenRenew && res.statusCode === 403) {
// token could be expired, try a new one
await this.tokenClient.login();
res = await request({
...requestOptions,
headers: {
...requestOptions.headers,
"X-Vault-Token": this.token,
},
});
requestOptions.headers = {
...requestOptions.headers,
"X-Vault-Token": this.token,
};
retry = true;
}

if (retry) {
res = await request(requestOptions);
}

if (!options.acceptedReturnCodes?.includes(res.statusCode)) {
Expand Down Expand Up @@ -202,4 +222,11 @@ export class Vault {

return errors.some((e) => e.includes(expectedMsg));
}

private async loadCACert(): Promise<void> {
if (this.config.vaultCaCertificatePath) {
const cert = await fs.readFile(this.config.vaultCaCertificatePath, "utf8");
this.config.vaultCaCertificate = cert;
}
}
}

0 comments on commit 6a0cad5

Please sign in to comment.