Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/php 8 2 #11

Merged
merged 14 commits into from
Mar 30, 2023
Merged

Add/php 8 2 #11

merged 14 commits into from
Mar 30, 2023

Conversation

ins0
Copy link
Member

@ins0 ins0 commented Mar 29, 2023

No description provided.

martin-helmich
martin-helmich reviewed Mar 29, 2023
View reviewed changes
Copy link
Member

@martin-helmich martin-helmich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the Psalm build failed for some reason; maybe we should setup an explicit PHP version for that build (seems to default to 8.1, right now). 🤔

.github/workflows/main.yml Outdated Show resolved Hide resolved
@ins0 ins0 mentioned this pull request Mar 29, 2023
Closed
@ins0 ins0 requested a review from martin-helmich March 30, 2023 08:03
@martin-helmich martin-helmich merged commit 0d9d78b into master Mar 30, 2023
@ins0 ins0 deleted the add/php-8-2 branch April 20, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-helmich martin-helmich martin-helmich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ins0 @martin-helmich